From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MtKZm-0007Z0-Cr
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 08:16:02 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MtKZh-0007Wm-3u
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 08:16:01 -0400
Received: from [199.232.76.173] (port=50775 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MtKZg-0007WZ-QS
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 08:15:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39424)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <kraxel@redhat.com>) id 1MtKZg-0008OV-Aa
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 08:15:56 -0400
Received: from int-mx01.intmail.prod.int.phx2.redhat.com
	(int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11])
	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n91CFtw7030808
	for <qemu-devel@nongnu.org>; Thu, 1 Oct 2009 08:15:55 -0400
Message-ID: <4AC49D79.9070800@redhat.com>
Date: Thu, 01 Oct 2009 14:15:53 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/6] virtio-console: Add a virtio-console
	bus, support for multiple ports
References: <1254225888-17093-3-git-send-email-amit.shah@redhat.com>
	<1254225888-17093-4-git-send-email-amit.shah@redhat.com>
	<4AC24C34.2080609@redhat.com>
	<20090930044724.GA28188@amit-x200.redhat.com>
	<4AC31E03.8000904@redhat.com>
	<20090930155534.GB1011@amit-x200.redhat.com>
	<4AC3A5E6.6070703@redhat.com>
	<20091001045439.GA18563@amit-x200.redhat.com>
	<4AC46A7A.6030809@redhat.com>
	<20091001085620.GB8385@amit-x200.redhat.com>
	<20091001104843.GA12334@amit-x200.redhat.com>
In-Reply-To: <20091001104843.GA12334@amit-x200.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org

   Hi,

> So we will have to spawn a console port at id 0 when the bus is
> initialised.
>
> There are a couple of problems though:
> - How to identify which chardev to associate the port#0 with?

I'd suggest to give the serial-bus a chardev attribute, which is then 
simply passed through, i.e.

   -device virtio-serial-bus,chardev=<name>

automatically creates a virtioconsole with port=0 and chardev=<name> on 
the newly created bus.

> - If there is a virtioconsole device specified on the command line,
>    should that be used as port0? Or should that mean we spawn two
>    consoles?

Two consoles.

> I guess for both these cases, some special command line tweaks will be
> needed? Or keep the old '-virtioconsole' parameter and put that up as
> port0?

See above.

Keeping -virtioconsole for backward compatibility is easy, it would 
basically create a chardev with a virtio<nr> label as it does today, 
then create virtio-serial-bus with chardev=virtio<nr>.

cheers,
   Gerd