From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MtLB7-0002Mv-T3
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 08:54:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MtLB1-0002Kd-ED
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 08:54:37 -0400
Received: from [199.232.76.173] (port=53510 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MtLB0-0002KU-CR
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 08:54:30 -0400
Received: from mail-px0-f203.google.com ([209.85.216.203]:52082)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1MtLAz-00009a-Cr
	for qemu-devel@nongnu.org; Thu, 01 Oct 2009 08:54:30 -0400
Received: by pxi41 with SMTP id 41so134976pxi.30
	for <qemu-devel@nongnu.org>; Thu, 01 Oct 2009 05:54:21 -0700 (PDT)
Message-ID: <4AC4A676.4050702@codemonkey.ws>
Date: Thu, 01 Oct 2009 07:54:14 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/6] char: Emit 'OPENED' events on char device
	open
References: <1254225888-17093-1-git-send-email-amit.shah@redhat.com>
	<1254225888-17093-2-git-send-email-amit.shah@redhat.com>
	<4AC3C9FD.3050705@codemonkey.ws>
	<20091001045622.GB18563@amit-x200.redhat.com>
In-Reply-To: <20091001045622.GB18563@amit-x200.redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org

Amit Shah wrote:
> On (Wed) Sep 30 2009 [16:13:33], Anthony Liguori wrote:
>   
>> Amit Shah wrote:
>>     
>>> Notify users of the char interface whenever the file / connection is
>>> opened.
>>>
>>> The existing RESET event is triggered when the qemu char state is reset
>>> as well; which may not be as interesting as char device open events.
>>>
>>> Signed-off-by: Amit Shah <amit.shah@redhat.com>
>>>   
>>>       
>> This series breaks the build (ppc440_bamboo.c).
>>     
>
> This patch or this series? If it's this patch, that's surprising!
>
>   
>> You should always build without an explicit --target-list to avoid this  
>> in the future.
>>     
>
> Sure -- I intend to when I send a request for the merging once all the
> comments have been sorted out.
>   

If you don't intend a patch series to be merged, then you should put 
[RFC] in the subject.

Regards,

Anthony Liguori