From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lars Kurth Subject: Re: Xen checkpatch infrastructure design Date: Mon, 24 Jul 2017 12:44:33 +0100 Message-ID: <4AD26A8C-DCDA-4BDF-8086-02F7ED4769CC@gmail.com> References: <54494f60-c3c3-1d13-28b7-03da33077376@suse.com> Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Content-Type: multipart/mixed; boundary="===============5046292903741322703==" Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dZbn4-0001Lb-6E for xen-devel@lists.xenproject.org; Mon, 24 Jul 2017 11:44:46 +0000 Received: by mail-wr0-f196.google.com with SMTP id o33so9752774wrb.1 for ; Mon, 24 Jul 2017 04:44:38 -0700 (PDT) In-Reply-To: <54494f60-c3c3-1d13-28b7-03da33077376@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Juergen Gross Cc: Lars Kurth , Wei Liu , Andrew Cooper , Ian Jackson , 'Jan Beulich' , xen-devel , cardoe List-Id: xen-devel@lists.xenproject.org --===============5046292903741322703== Content-Type: multipart/alternative; boundary="Apple-Mail=_3CB1D9DC-0860-4F9B-8A8D-3B4EC57B5A71" --Apple-Mail=_3CB1D9DC-0860-4F9B-8A8D-3B4EC57B5A71 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii CC'ing Doug Goldstein as he has been reviewing some of Ishani's work = (see below) Both Andy Cooper and Doug Goldstein had done some groundwork earlier on = this topic > On 24 Jul 2017, at 09:50, Juergen Gross wrote: >=20 > On the Xen Developer Summit 2017 in Budapest we agreed to add a > script to the Xen repository capable to test patches for style > correctness, similar to checkpatch.pl of the Linux kernel. >=20 > This is a first draft of the interface visible to users and > developers. ... > RFC: Design Considerations > -------------------------- > Remains the question how to design the style checker itself. It could > be: >=20 > (a) a monolithic script (perl, python, whatever) being capable of > handling all the different coding styles > (b) a main script checking the patch header and calling a code style > specific script for each source file modified by the patch >=20 > I believe (b) would be easier to maintain and to develop (we could = start > with the main script and add style specific scripts later). I don't have a view on this, but wanted to point the following docs = which cover a little bit of groundwork on the subject, that can possibly = be built upon = https://docs.google.com/document/d/10NJn-QvO1TvyJJJGE2PD6FtElYCT3neBAffIqe= WHdiE/edit = http://markmail.org/message/tmdv2zzd4dvjin7v = Regards Lars= --Apple-Mail=_3CB1D9DC-0860-4F9B-8A8D-3B4EC57B5A71 Content-Transfer-Encoding: quoted-printable Content-Type: text/html; charset=us-ascii CC'ing Doug Goldstein as he has been reviewing some of = Ishani's work (see below)

Both Andy Cooper and Doug = Goldstein had done some groundwork earlier on this topic

On 24 Jul 2017, at 09:50, Juergen Gross = <jgross@suse.com> = wrote:

On the Xen Developer Summit 2017 in Budapest we agreed to add = a
script to the Xen repository capable to test patches for = style
correctness, similar to checkpatch.pl of the Linux = kernel.

This is a first draft of the = interface visible to users and
developers.

...

RFC: Design Considerations
--------------------------
Remains the question = how to design the style checker itself. It could
be:

(a) a monolithic script (perl, python, = whatever) being capable of
handling all = the different coding styles
(b) a main script checking the = patch header and calling a code style
= specific script for each source file modified by the = patch

I believe (b) would be easier to = maintain and to develop (we could start
with the main = script and add style specific scripts later).

I= don't have a view on this, but wanted to point the following docs which = cover a little bit of groundwork on the subject, that can possibly be = built upon

https://docs.google.com/document/d/10NJn-QvO1TvyJJJGE2PD6FtElYC= T3neBAffIqeWHdiE/edit

http://markmail.org/message/tmdv2zzd4dvjin7v

Regards

Lars

= --Apple-Mail=_3CB1D9DC-0860-4F9B-8A8D-3B4EC57B5A71-- --===============5046292903741322703== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5046292903741322703==--