All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Wiles, Keith" <keith.wiles@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: "dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH 2/6] net/tap: allow full length names
Date: Fri, 11 Jan 2019 19:32:39 +0000	[thread overview]
Message-ID: <4AD48FCF-86CB-4C59-AF54-00850FA476D5@intel.com> (raw)
In-Reply-To: <20190111180659.5972-3-stephen@networkplumber.org>



> On Jan 11, 2019, at 12:06 PM, Stephen Hemminger <stephen@networkplumber.org> wrote:
> 
> The code for set_interface_name was incorrectly assuming that
> space for null byte was necessary with snprintf/strlcpy.
> 
> Fixes: 02f96a0a82d1 ("net/tap: add TUN/TAP device PMD")
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> drivers/net/tap/rte_eth_tap.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c
> index 1c00681ba0eb..d7f77d664502 100644
> --- a/drivers/net/tap/rte_eth_tap.c
> +++ b/drivers/net/tap/rte_eth_tap.c
> @@ -1892,10 +1892,10 @@ set_interface_name(const char *key __rte_unused,
> 	char *name = (char *)extra_args;
> 
> 	if (value)
> -		strlcpy(name, value, RTE_ETH_NAME_MAX_LEN - 1);
> +		strlcpy(name, value, RTE_ETH_NAME_MAX_LEN);
> 	else
> -		snprintf(name, RTE_ETH_NAME_MAX_LEN - 1, "%s%d",
> -			 DEFAULT_TAP_NAME, (tap_unit - 1));
> +		snprintf(name, RTE_ETH_NAME_MAX_LEN, "%s%d",
> +			 DEFAULT_TAP_NAME, tun_unit - 1);

Was this meant to change from tap_unit to tun_unit here, if so why?
> 
> 	return 0;
> }
> -- 
> 2.20.1
> 

Regards,
Keith

  reply	other threads:[~2019-01-11 19:32 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-11 18:06 [PATCH 0/6] net/tap: fixes and cleanups Stephen Hemminger
2019-01-11 18:06 ` [PATCH 1/6] net/tap: use strlcpy for interface name Stephen Hemminger
2019-01-11 18:06 ` [PATCH 2/6] net/tap: allow full length names Stephen Hemminger
2019-01-11 19:32   ` Wiles, Keith [this message]
2019-01-11 19:48     ` Stephen Hemminger
2019-01-11 19:49       ` Wiles, Keith
2019-01-11 18:06 ` [PATCH 3/6] net/tap: check interface name in kvargs Stephen Hemminger
2019-01-11 19:37   ` Wiles, Keith
2019-01-11 19:49     ` Stephen Hemminger
2019-01-11 19:50       ` Wiles, Keith
2019-01-15  2:01         ` Thomas Monjalon
2019-01-11 22:20     ` Luse, Paul E
2019-01-11 18:06 ` [PATCH 4/6] net/tap: lower the priority of log messages Stephen Hemminger
2019-01-11 18:06 ` [PATCH 5/6] net/tap: let kernel choose tun device name Stephen Hemminger
2019-01-11 19:43   ` Wiles, Keith
2019-01-11 18:06 ` [PATCH 6/6] net/tap: get rid of global tuntap_name Stephen Hemminger
2019-01-11 19:47 ` [PATCH 0/6] net/tap: fixes and cleanups Wiles, Keith
2019-01-11 20:35 ` [PATCH v2 " Stephen Hemminger
2019-01-11 20:35   ` [PATCH v2 1/7] net/tap: use strlcpy for interface name Stephen Hemminger
2019-01-11 20:35   ` [PATCH v2 2/7] net/tap: allow full length names Stephen Hemminger
2019-01-11 20:35   ` [PATCH v2 3/7] net/tap: check interface name in kvargs Stephen Hemminger
2019-01-11 20:35   ` [PATCH v2 4/7] net/tap: lower the priority of log messages Stephen Hemminger
2019-01-11 20:35   ` [PATCH v2 5/7] net/tap: let kernel choose tun device name Stephen Hemminger
2019-01-11 20:35   ` [PATCH v2 6/7] net/tap: get rid of global tuntap_name Stephen Hemminger
2019-01-11 20:35   ` [PATCH v2 7/7] net/tap: don't print pointer in info message Stephen Hemminger
2019-01-14 14:10     ` Ferruh Yigit
2019-01-14 15:07     ` Wiles, Keith
2019-01-14 14:10   ` [PATCH v2 0/6] net/tap: fixes and cleanups Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AD48FCF-86CB-4C59-AF54-00850FA476D5@intel.com \
    --to=keith.wiles@intel.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.