All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kazuhito Hagio <k-hagio@ab.jp.nec.com>
To: Dave Jones <davej@codemonkey.org.uk>
Cc: "kexec@lists.infradead.org" <kexec@lists.infradead.org>
Subject: RE: makedumpfile: Fix divide by zero in print_report()
Date: Fri, 27 Sep 2019 20:39:04 +0000	[thread overview]
Message-ID: <4AE2DC15AC0B8543882A74EA0D43DBEC035909ED@BPXM09GP.gisp.nec.co.jp> (raw)
In-Reply-To: <20190926193253.GA10258@codemonkey.org.uk>

> -----Original Message-----
> On Thu, Sep 26, 2019 at 06:41:48PM +0000, Kazuhito Hagio wrote:
> 
>  > > -----Original Message-----
>  > > If info->max_mapnr and pfn_memhole are equal, we divide by zero when
>  > > trying determine the 'shrinking' value.
>  > >
>  > > On the system I saw this error, we arrived at this function with
>  > > info->max_mapnr:0x0000000001080000 pfn_memhole:0x0000000001080000
>  >
>  > Thank you for the patch.
>  > I suppose that you see the error with the -E option, right?
>  >
>  > It seems that the -E option has some problems with its statistics,
>  > so I'm checking whether there is a better way to fix this.
> 
> Yes, we use the -E option.
> We manage to get useful info from the generated dump after this fix, so
> it seems it only affects the statistics output.

OK, the statistics in cyclic mode with the -E option is completely wrong
but a possible fix is likely to affect the whole of cyclic processing, so
I just cover the hole with your patch and leave the statistics problem as
a known issue at this time.  I would revisit it when I have time.

The patch was applied to the devel branch.

Thanks,
Kazu



_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2019-09-27 20:40 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20190924194005.GA7666@codemonkey.org.uk>
2019-09-26 18:41 ` makedumpfile: Fix divide by zero in print_report() Kazuhito Hagio
2019-09-26 19:32   ` Dave Jones
2019-09-27 20:39     ` Kazuhito Hagio [this message]
2019-10-04 17:03       ` Dave Jones
2019-10-07 20:13         ` Kazuhito Hagio
2019-10-08 21:37           ` Dave Jones

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE2DC15AC0B8543882A74EA0D43DBEC035909ED@BPXM09GP.gisp.nec.co.jp \
    --to=k-hagio@ab.jp.nec.com \
    --cc=davej@codemonkey.org.uk \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.