Re: [PATCH 1/1] MSVC: port pthread code to native Windows threads

From: Joshua Jensen <jjensen@workspacewhiz.com>
To: git@vger.kernel.org
Subject: Re: [PATCH 1/1] MSVC: port pthread code to native Windows threads
Date: Tue, 03 Nov 2009 19:34:42 -0700	[thread overview]
Message-ID: <4AF0E842.2010201@workspacewhiz.com> (raw)
In-Reply-To: <alpine.DEB.1.00.0911040031210.4985@pacific.mpi-cbg.de>

----- Original Message -----
From: Johannes Schindelin
Date: 11/3/2009 4:38 PM
>>   #ifdef THREADED_DELTA_SEARCH
>> -#include "thread-utils.h"
>> -#include<pthread.h>
>> +# include "thread-utils.h"
>> +# ifndef _WIN32
>> +#  include<pthread.h>
>> +# else
>> +#  include<winthread.h>
>> +# endif
>>   #endif
>>
>>      
> It is unlikely that an #ifdef "contamination" of this extent will go
> through easily, but I have a suggestion that may make your patch both
> easier to read and more likely to be accepted into git.git: Try to wrap
> the win32 calls into pthread-compatible function signatures.  Then you can
> add a compat/win32/pthread.h and not even touch core files of git.git at
> all.
>    
Pardon my ignorance, but is there a reason to not use Pthreads for 
Win32?  http://sourceware.org/pthreads-win32/

Josh