All of lore.kernel.org
 help / color / mirror / Atom feed
From: John Hughes <john@Calva.COM>
To: John Hughes <john@Calva.COM>
Cc: linux-scsi@vger.kernel.org
Subject: Re: ses enclosure stuff not working with Promise Vtrak J610S JBOD
Date: Wed, 04 Nov 2009 17:55:09 +0100	[thread overview]
Message-ID: <4AF1B1ED.1090104@Calva.COM> (raw)
In-Reply-To: <4AF1A2F0.7060201@Calva.COM>

John Hughes wrote:
> Attempts to change the "status" fail:
>
> # echo "unconfigured" > status
> [  626.389093] general protection fault: 0000 [#1] SMP [  626.389243] 
> last sysfs file: /sys/class/enclosure/0:0:32:0/0/status
This bug still exists in 2.6.32-rc6.

It's pretty crazy - if we use a legal value then the routine correctly 
returns -EINVAL as there is no setter.

If we write an illegal value to status we get an oops!

Aha!  It's because the enclosure_status array is not NULL terminated, so 
if we try to write an illegal value we run off the end of the array!




      parent reply	other threads:[~2009-11-04 16:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-04 13:00 ses enclosure stuff not working with Promise Vtrak J610S JBOD John Hughes
2009-11-04 15:17 ` John Hughes
2009-11-04 15:22 ` James Bottomley
2009-11-04 15:53   ` John Hughes
2009-11-04 16:07     ` James Bottomley
2009-11-04 16:12       ` John Hughes
2009-11-04 16:20         ` James Bottomley
2009-11-04 18:01           ` John Hughes
2009-11-04 18:05             ` James Bottomley
2009-11-04 18:10               ` John Hughes
2009-11-05  9:41             ` John Hughes
2009-11-05 15:30               ` John Hughes
2009-11-05 15:44                 ` James Bottomley
2009-11-04 15:51 ` John Hughes
2009-11-04 16:54   ` John Hughes
2009-11-04 16:55   ` John Hughes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF1B1ED.1090104@Calva.COM \
    --to=john@calva.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.