All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joonyoung Shim <jy0922.shim@samsung.com>
To: Jassi Brar <jassi.brar@samsung.com>
Cc: alsa-devel@alsa-project.org, broonie@opensource.wolfsonmicro.com,
	ben-linux@fluff.org
Subject: Re: [PATCH 1/7] S3C AUDIO: Rename s3c24xx_pcm prefix to	s3c_dma
Date: Thu, 05 Nov 2009 12:14:41 +0900	[thread overview]
Message-ID: <4AF24321.7070303@samsung.com> (raw)
In-Reply-To: <1257384866-18188-1-git-send-email-jassi.brar@samsung.com>

On 11/5/2009 10:34 AM, Jassi Brar wrote:
> The s3c24xx_pcm prefix for the soc_platform is inappropriate when
> some Samsung SoCs have PCM controllers which will eventually have
> drivers and hence namespace ambiguities.
> 
> To resolve naming ambiguities in future the following have been
> renamed in order
> 1) s3c24xx_pcm_dma_params -> s3c_audio_dma_params
> 2) s3c24xx_pcm_preallocate_dma_buffer -> s3c_preallocate_dma_buffer
> 3) s3c24xx_pcm_dmamask -> s3c_dmamask
> 4) s3c24xx_pcm_XXX -> s3c_dma_XXX
> 

I think that it should have a consistent prefix: s3c_audio_dma_ or
other prefix.

BTW, should we keep up s3c prefix? If we will change the prefix now, it
is a chance alterable from s3c prefix to other prefix because there is a
variety of samsung SoCs unused s3c prefix.

  reply	other threads:[~2009-11-05  3:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-05  1:34 [PATCH 1/7] S3C AUDIO: Rename s3c24xx_pcm prefix to s3c_dma Jassi Brar
2009-11-05  3:14 ` Joonyoung Shim [this message]
2009-11-05  4:16   ` jassi brar
2009-11-05  5:03     ` Joonyoung Shim
2009-11-06 16:23       ` Mark Brown
2009-11-07  3:46         ` jassi brar
2009-11-09  5:14           ` Joonyoung Shim
2009-11-09  5:31             ` jassi brar
2009-11-09  6:19               ` Joonyoung Shim
2009-11-09 12:05                 ` Mark Brown
2009-11-11  4:44 Jassi Brar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AF24321.7070303@samsung.com \
    --to=jy0922.shim@samsung.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=ben-linux@fluff.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=jassi.brar@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.