From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1N7aAa-0008Ch-LH
	for qemu-devel@nongnu.org; Mon, 09 Nov 2009 14:44:56 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1N7aAV-00088b-S5
	for qemu-devel@nongnu.org; Mon, 09 Nov 2009 14:44:56 -0500
Received: from [199.232.76.173] (port=36657 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1N7aAV-00088M-Ms
	for qemu-devel@nongnu.org; Mon, 09 Nov 2009 14:44:51 -0500
Received: from ey-out-1920.google.com ([74.125.78.149]:8580)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1N7aAV-0007xJ-CM
	for qemu-devel@nongnu.org; Mon, 09 Nov 2009 14:44:51 -0500
Received: by ey-out-1920.google.com with SMTP id 3so3052376eyh.14
	for <qemu-devel@nongnu.org>; Mon, 09 Nov 2009 11:44:50 -0800 (PST)
Message-ID: <4AF87124.50204@codemonkey.ws>
Date: Mon, 09 Nov 2009 13:44:36 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 9/9] Move mp_state to CPU_COMMON
References: <1256152621-18863-1-git-send-email-agraf@suse.de>
	<1256152621-18863-2-git-send-email-agraf@suse.de>
	<1256152621-18863-3-git-send-email-agraf@suse.de>
	<1256152621-18863-4-git-send-email-agraf@suse.de>
	<1256152621-18863-5-git-send-email-agraf@suse.de>
	<1256152621-18863-6-git-send-email-agraf@suse.de>
	<1256152621-18863-7-git-send-email-agraf@suse.de>
	<1256152621-18863-8-git-send-email-agraf@suse.de>
	<1256152621-18863-9-git-send-email-agraf@suse.de>
	<1256152621-18863-10-git-send-email-agraf@suse.de>
	<1256852394.9044.118.camel@slab.beaverton.ibm.com>
	<31B0F419-D1B8-4E5C-A134-B3593A898B09@suse.de>
In-Reply-To: <31B0F419-D1B8-4E5C-A134-B3593A898B09@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Carsten Otte <cotte@de.ibm.com>, qemu-devel <qemu-devel@nongnu.org>, Hollis Blanchard <hollisb@us.ibm.com>

Alexander Graf wrote:
>
> On 29.10.2009, at 22:39, Hollis Blanchard wrote:
>
>> On Wed, 2009-10-21 at 21:17 +0200, Alexander Graf wrote:
>>> MP State is implemented in the generic code, so let's move the variable
>>> it accesses to generic code as well.
>>>
>>> Still unbreaks PPC and now even S390x w/ KVM.
>>>
>>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>
>> Acked-by: Hollis Blanchard <hollisb@us.ibm.com>
>>
>> Anthony, this patch fixes a build break in PowerPC KVM. Arguably it
>> should not be patch 9/9 in an S390 series, but in any case please apply
>> it. :)
>
> Anthony, could you please apply it? Not having S390 support is 
> pitiful, but having PPC break too is even worse!

 mp_state does not belong in CPU_COMMON.

Regards,

Anthony Liguori

> Alex
>