From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"Jiang, Yunhong" <yunhong.jiang@intel.com>,
Keir Fraser <keir.fraser@eu.citrix.com>
Subject: Re: Re: [PATCH] Add hypercall to expose physical CPU in xen hypervisor
Date: Tue, 10 Nov 2009 10:00:25 -0800 [thread overview]
Message-ID: <4AF9AA39.4070206@goop.org> (raw)
In-Reply-To: <20091110163626.GC23000@phenom.dumpdata.com>
On 11/10/09 08:36, Konrad Rzeszutek Wilk wrote:
> Here is what checkpatch says:
>
> WARNING: do not add new typedefs
> #523: FILE: include/xen/interface/platform.h:328:
> +typedef struct xen_physical_cpuinfo xen_physical_cpuinfo_t;
>
> WARNING: do not add new typedefs
> #537: FILE: include/xen/interface/platform.h:342:
> +typedef struct xenpf_pcpu_info xenpf_pcpu_info_t;
>
> total: 0 errors, 2 warnings, 564 lines checked
>
> /home/konrad/01-dom0_pcpu.patch has style problems, please review. If any of these errors
> are false positives report them to the maintainer, see
> CHECKPATCH in MAINTAINERS.
>
Unfortunately I think the typedefs are necessary for the GUEST_HANDLE stuff.
J
next prev parent reply other threads:[~2009-11-10 18:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-06 8:20 [PATCH] Add hypercall to expose physical CPU in xen hypervisor Jiang, Yunhong
2009-11-06 16:30 ` Keir Fraser
2009-11-08 1:59 ` Jiang, Yunhong
2009-11-08 7:46 ` Keir Fraser
2009-11-09 0:45 ` Jiang, Yunhong
2009-11-09 22:03 ` Jeremy Fitzhardinge
2009-11-10 12:16 ` Jiang, Yunhong
2009-11-10 16:36 ` Konrad Rzeszutek Wilk
2009-11-10 18:00 ` Jeremy Fitzhardinge [this message]
2009-11-10 12:02 ` Jiang, Yunhong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AF9AA39.4070206@goop.org \
--to=jeremy@goop.org \
--cc=keir.fraser@eu.citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xensource.com \
--cc=yunhong.jiang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.