All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Andrea.Amorosi76@gmail.com" <Andrea.Amorosi76@gmail.com>
To: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: [PATCH] em28xx: fix for Dikom DK300 hybrid USB tuner (aka Kworld VS-DVB-T 323UR )
Date: Sun, 22 Nov 2009 12:02:15 +0100	[thread overview]
Message-ID: <4B091A37.5020408@gmail.com> (raw)
In-Reply-To: <829197380911140634j49c05cd0s90aed57b9ae61436@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 2643 bytes --]

This patch fix the Dikom DK300 hybrid usb card which is recognized as a
Kworld VS-DVB-T 323UR (card=54).

The patch adds digital tv and solves analogue tv audio bad quality issue.
Moreover it removes the composite and s-video analogue inputs which are 
not present on the board.

Not tested: remote controller
To be done: I attach the usbsnoop obtained some month ago using windows xp.
It seems that with the proposed patch the digital demodulator remains 
activated if the tuner is switched from digital to analogue mode.
Workaorund is to unplug and replug the device when switching from 
digital to analogue.
If someone can explain how to verify the gpio settings using the 
usbsnoop, the above issue perhaps can be resolved.

Signed-off-by: Andrea Amorosi <Andrea.Amorosi76@gmail.com>

diff -r aba823ecaea6 linux/drivers/media/video/em28xx/em28xx-cards.c
--- a/linux/drivers/media/video/em28xx/em28xx-cards.c	Thu Nov 12 
12:21:05 2009 -0200
+++ b/linux/drivers/media/video/em28xx/em28xx-cards.c	Sun Nov 22 
11:50:29 2009 +0100
@@ -1422,19 +1422,25 @@
  		.tuner_type   = TUNER_XC2028,
  		.tuner_gpio   = default_tuner_gpio,
  		.decoder      = EM28XX_TVP5150,
+                .mts_firmware = 1,
+                .has_dvb      = 1,
+                .dvb_gpio     = kworld_330u_digital, 
 

  		.input        = { {
  			.type     = EM28XX_VMUX_TELEVISION,
  			.vmux     = TVP5150_COMPOSITE0,
  			.amux     = EM28XX_AMUX_VIDEO,
-		}, {
+			.gpio     = default_analog,
+		},/* {
  			.type     = EM28XX_VMUX_COMPOSITE1,
  			.vmux     = TVP5150_COMPOSITE1,
  			.amux     = EM28XX_AMUX_LINE_IN,
+			.gpio     = kworld_330u_analog,
  		}, {
  			.type     = EM28XX_VMUX_SVIDEO,
  			.vmux     = TVP5150_SVIDEO,
  			.amux     = EM28XX_AMUX_LINE_IN,
-		} },
+			.gpio     = kworld_330u_analog,
+		} */},
  	},
  	[EM2882_BOARD_TERRATEC_HYBRID_XS] = {
  		.name         = "Terratec Hybrid XS (em2882)",
@@ -2143,6 +2149,7 @@
  		ctl->demod = XC3028_FE_DEFAULT;
  		break;
  	case EM2883_BOARD_KWORLD_HYBRID_330U:
+	case EM2882_BOARD_KWORLD_VS_DVBT:
  		ctl->demod = XC3028_FE_CHINA;
  		ctl->fname = XC2028_DEFAULT_FIRMWARE;
  		break;
diff -r aba823ecaea6 linux/drivers/media/video/em28xx/em28xx-dvb.c
--- a/linux/drivers/media/video/em28xx/em28xx-dvb.c	Thu Nov 12 12:21:05 
2009 -0200
+++ b/linux/drivers/media/video/em28xx/em28xx-dvb.c	Sun Nov 22 11:50:29 
2009 +0100
@@ -504,6 +504,7 @@
  		break;
  	case EM2880_BOARD_TERRATEC_HYBRID_XS:
  	case EM2881_BOARD_PINNACLE_HYBRID_PRO:
+	case EM2882_BOARD_KWORLD_VS_DVBT:
  		dvb->frontend = dvb_attach(zl10353_attach,
  					   &em28xx_zl10353_xc3028_no_i2c_gate,
  					   &dev->i2c_adap);



[-- Attachment #2: parsed_UsbSnoop.log.tar.gz --]
[-- Type: application/gzip, Size: 36519 bytes --]

  parent reply	other threads:[~2009-11-22 11:33 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-14 11:22 [PATCH] em28xx: fix for Dikom DK300 hybrid USB tuner (aka Kworld VS-DVB-T 323UR ) (digital mode) Andrea.Amorosi76
2009-11-14 13:05 ` Andrea.Amorosi76
2009-11-14 14:34   ` Devin Heitmueller
2009-11-14 22:21     ` [PATCH] em28xx: fix for Dikom DK300 hybrid USB tuner (aka Kworld VS-DVB-T 323UR ) Andrea.Amorosi76
2009-11-14 22:47       ` Andrea.Amorosi76
     [not found]     ` <4AFF1203.3080401@gmail.com>
     [not found]       ` <829197380911150719w7ea0749ei2a1350f1e12b866d@mail.gmail.com>
     [not found]         ` <4B001ECD.9030609@gmail.com>
     [not found]           ` <829197380911152055w233edf18ve36b821571198d04@mail.gmail.com>
     [not found]             ` <4B01B168.50403@gmail.com>
2009-11-16 20:28               ` [PATCH] em28xx: fix for Dikom DK300 hybrid USB tuner (aka Kworld VS-DVB-T 323UR ) (digital mode) Devin Heitmueller
     [not found]                 ` <4B01B841.7000506@gmail.com>
2009-11-16 20:47                   ` Devin Heitmueller
     [not found]                 ` <4B01BABE.4060609@gmail.com>
2009-11-16 20:56                   ` Devin Heitmueller
2009-11-18 18:59                     ` Andrea.Amorosi76
2009-11-22 11:02     ` Andrea.Amorosi76 [this message]
2010-01-30 17:10     ` [PATCH] em28xx: add Dikom DK300 hybrid USB tuner Andrea.Amorosi76
2010-02-03 18:45     ` Andrea.Amorosi76
2010-02-09 18:43     ` Andrea.Amorosi76
2010-02-09 19:21       ` Mauro Carvalho Chehab
2010-02-09 20:10         ` Andrea.Amorosi76
2010-02-09 21:04           ` Mauro Carvalho Chehab
2010-02-09 20:53         ` Andrea.Amorosi76
2010-02-09 21:13           ` Mauro Carvalho Chehab
2010-02-10 23:15           ` Mauro Carvalho Chehab

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B091A37.5020408@gmail.com \
    --to=andrea.amorosi76@gmail.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.