From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1ND0YC-0006x9-SV
	for qemu-devel@nongnu.org; Tue, 24 Nov 2009 13:55:44 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1ND0Y8-0006uu-6a
	for qemu-devel@nongnu.org; Tue, 24 Nov 2009 13:55:44 -0500
Received: from [199.232.76.173] (port=33040 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1ND0Y8-0006uo-2O
	for qemu-devel@nongnu.org; Tue, 24 Nov 2009 13:55:40 -0500
Received: from mail-bw0-f212.google.com ([209.85.218.212]:52063)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1ND0Y7-0003Ms-JX
	for qemu-devel@nongnu.org; Tue, 24 Nov 2009 13:55:39 -0500
Received: by bwz4 with SMTP id 4so8347022bwz.2
	for <qemu-devel@nongnu.org>; Tue, 24 Nov 2009 10:55:38 -0800 (PST)
Message-ID: <4B0C2C24.9060107@codemonkey.ws>
Date: Tue, 24 Nov 2009 12:55:32 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 10/13] Implement early printk in
	virtio-console
References: <1259083781-14642-1-git-send-email-agraf@suse.de>
	<1259083781-14642-11-git-send-email-agraf@suse.de>
In-Reply-To: <1259083781-14642-11-git-send-email-agraf@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexander Graf <agraf@suse.de>
Cc: Carsten Otte <cotte@de.ibm.com>, qemu-devel@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>

Alexander Graf wrote:
> On our S390x Virtio machine we don't have anywhere to display early printks
> on, because we don't know about VGA or serial ports.
>
> So instead we just forward everything to the virtio console that we created
> anyways.
>   

What is this used for?

> Signed-off-by: Alexander Graf <agraf@suse.de>
> ---
>  hw/virtio-console.c |    7 +++++++
>  hw/virtio-console.h |    2 ++
>  2 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/hw/virtio-console.c b/hw/virtio-console.c
> index 57f8f89..cd6cf20 100644
> --- a/hw/virtio-console.c
> +++ b/hw/virtio-console.c
> @@ -105,6 +105,13 @@ static void vcon_event(void *opaque, int event)
>      /* we will ignore any event for the time being */
>  }
>  
> +void virtio_console_print_early(VirtIODevice *vdev, uint8_t *buf)
> +{
> +    VirtIOConsole *s = to_virtio_console(vdev);
> +
> +    qemu_chr_write(s->chr, buf, strlen((char*)buf));
> +}
> +
>  static void virtio_console_save(QEMUFile *f, void *opaque)
>  {
>      VirtIOConsole *s = opaque;
> diff --git a/hw/virtio-console.h b/hw/virtio-console.h
> index 84d0717..f3ccc3c 100644
> --- a/hw/virtio-console.h
> +++ b/hw/virtio-console.h
> @@ -16,4 +16,6 @@
>  /* The ID for virtio console */
>  #define VIRTIO_ID_CONSOLE 3
>  
> +void virtio_console_print_early(VirtIODevice *vdev, uint8_t *buf);
> +
>  #endif
>