From mboxrd@z Thu Jan 1 00:00:00 1970 From: "H. Peter Anvin" Date: Sat, 09 Jan 2010 00:16:10 +0000 Subject: Re: [PATCH] Makefile: do not override LC_CTYPE Message-Id: <4B47CACA.7080103@zytor.com> List-Id: References: <20100108115745.GA14758@sepie.suse.cz> <1262952988-16563-1-git-send-email-mmarek@suse.cz> <4B47C94E.8070302@redhat.com> In-Reply-To: <4B47C94E.8070302@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Masami Hiramatsu Cc: Michal Marek , Simon Horman , Roland Dreier , Sam Ravnborg , Sergei Trofimovich , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org On 01/08/2010 04:09 PM, Masami Hiramatsu wrote: > Hi Michal, > > Michal Marek wrote: >> Setting LC_CTYPE=C breaks localized messages in some setups. With only >> LC_COLLATE=C and LC_NUMERIC=C, we get almost all we need, except for not >> so defined character classes and tolower()/toupper(). The former is not >> a big issue, because we can assume that e.g. [:alpha:] will always >> include a-zA-Z and we only ever process ASCII input. The latter seems >> only affect arch/sh/tools/gen-mach-types, which we can handle separately. > > Hmm, this also affects arch/x/tools/gen-insn-attr-x86.awk. > Could you also wrap it? > This is tolower/toupper()? Do there exist locales where tolower/toupper on ASCII input do weird things, or are we merely hypothesizing? -hpa From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754407Ab0AIAQi (ORCPT ); Fri, 8 Jan 2010 19:16:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752994Ab0AIAQh (ORCPT ); Fri, 8 Jan 2010 19:16:37 -0500 Received: from terminus.zytor.com ([198.137.202.10]:41126 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750781Ab0AIAQg (ORCPT ); Fri, 8 Jan 2010 19:16:36 -0500 Message-ID: <4B47CACA.7080103@zytor.com> Date: Fri, 08 Jan 2010 16:16:10 -0800 From: "H. Peter Anvin" User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-4.fc12 Thunderbird/3.0 MIME-Version: 1.0 To: Masami Hiramatsu CC: Michal Marek , Simon Horman , Roland Dreier , Sam Ravnborg , Sergei Trofimovich , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH] Makefile: do not override LC_CTYPE References: <20100108115745.GA14758@sepie.suse.cz> <1262952988-16563-1-git-send-email-mmarek@suse.cz> <4B47C94E.8070302@redhat.com> In-Reply-To: <4B47C94E.8070302@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/08/2010 04:09 PM, Masami Hiramatsu wrote: > Hi Michal, > > Michal Marek wrote: >> Setting LC_CTYPE=C breaks localized messages in some setups. With only >> LC_COLLATE=C and LC_NUMERIC=C, we get almost all we need, except for not >> so defined character classes and tolower()/toupper(). The former is not >> a big issue, because we can assume that e.g. [:alpha:] will always >> include a-zA-Z and we only ever process ASCII input. The latter seems >> only affect arch/sh/tools/gen-mach-types, which we can handle separately. > > Hmm, this also affects arch/x/tools/gen-insn-attr-x86.awk. > Could you also wrap it? > This is tolower/toupper()? Do there exist locales where tolower/toupper on ASCII input do weird things, or are we merely hypothesizing? -hpa