From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Date: Sat, 09 Jan 2010 00:53:50 +0000 Subject: Re: [PATCH] Makefile: do not override LC_CTYPE Message-Id: <4B47D39E.20104@redhat.com> List-Id: References: <20100108115745.GA14758@sepie.suse.cz> <1262952988-16563-1-git-send-email-mmarek@suse.cz> <4B47C94E.8070302@redhat.com> <4B47CACA.7080103@zytor.com> In-Reply-To: <4B47CACA.7080103@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: "H. Peter Anvin" Cc: Michal Marek , Simon Horman , Roland Dreier , Sam Ravnborg , Sergei Trofimovich , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org H. Peter Anvin wrote: > On 01/08/2010 04:09 PM, Masami Hiramatsu wrote: >> Hi Michal, >> >> Michal Marek wrote: >>> Setting LC_CTYPE=C breaks localized messages in some setups. With only >>> LC_COLLATE=C and LC_NUMERIC=C, we get almost all we need, except for not >>> so defined character classes and tolower()/toupper(). The former is not >>> a big issue, because we can assume that e.g. [:alpha:] will always >>> include a-zA-Z and we only ever process ASCII input. The latter seems >>> only affect arch/sh/tools/gen-mach-types, which we can handle separately. >> >> Hmm, this also affects arch/x/tools/gen-insn-attr-x86.awk. >> Could you also wrap it? >> > > This is tolower/toupper()? Do there exist locales where tolower/toupper > on ASCII input do weird things, or are we merely hypothesizing? Ah, sorry, I was just hypothesizing. --- #!/bin/sh # en_US locale sorts alphabets as AaBb... LANG=en_US LC_ALLLC_COLLATE=C LC_NUMERIC=C export LC_COLLATE LC_NUMERIC awk 'BEGIN{if (match("C","[a-z]")) {print "NG"} else {print "OK"} exit;}' --- this returns "OK". So, the patch is OK for me too. Thanks, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753438Ab0AIAyE (ORCPT ); Fri, 8 Jan 2010 19:54:04 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753257Ab0AIAyD (ORCPT ); Fri, 8 Jan 2010 19:54:03 -0500 Received: from mx1.redhat.com ([209.132.183.28]:37517 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751644Ab0AIAyA (ORCPT ); Fri, 8 Jan 2010 19:54:00 -0500 Message-ID: <4B47D39E.20104@redhat.com> Date: Fri, 08 Jan 2010 19:53:50 -0500 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: "H. Peter Anvin" CC: Michal Marek , Simon Horman , Roland Dreier , Sam Ravnborg , Sergei Trofimovich , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH] Makefile: do not override LC_CTYPE References: <20100108115745.GA14758@sepie.suse.cz> <1262952988-16563-1-git-send-email-mmarek@suse.cz> <4B47C94E.8070302@redhat.com> <4B47CACA.7080103@zytor.com> In-Reply-To: <4B47CACA.7080103@zytor.com> X-Enigmail-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org H. Peter Anvin wrote: > On 01/08/2010 04:09 PM, Masami Hiramatsu wrote: >> Hi Michal, >> >> Michal Marek wrote: >>> Setting LC_CTYPE=C breaks localized messages in some setups. With only >>> LC_COLLATE=C and LC_NUMERIC=C, we get almost all we need, except for not >>> so defined character classes and tolower()/toupper(). The former is not >>> a big issue, because we can assume that e.g. [:alpha:] will always >>> include a-zA-Z and we only ever process ASCII input. The latter seems >>> only affect arch/sh/tools/gen-mach-types, which we can handle separately. >> >> Hmm, this also affects arch/x/tools/gen-insn-attr-x86.awk. >> Could you also wrap it? >> > > This is tolower/toupper()? Do there exist locales where tolower/toupper > on ASCII input do weird things, or are we merely hypothesizing? Ah, sorry, I was just hypothesizing. --- #!/bin/sh # en_US locale sorts alphabets as AaBb... LANG=en_US LC_ALL= LC_COLLATE=C LC_NUMERIC=C export LC_COLLATE LC_NUMERIC awk 'BEGIN{if (match("C","[a-z]")) {print "NG"} else {print "OK"} exit;}' --- this returns "OK". So, the patch is OK for me too. Thanks, -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com