From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Date: Sat, 09 Jan 2010 01:07:47 +0000 Subject: Re: [PATCH] Makefile: do not override LC_CTYPE Message-Id: <4B47D6E3.8080300@redhat.com> List-Id: References: <20100108115745.GA14758@sepie.suse.cz> <1262952988-16563-1-git-send-email-mmarek@suse.cz> In-Reply-To: <1262952988-16563-1-git-send-email-mmarek@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Michal Marek Cc: "H. Peter Anvin" , Simon Horman , Roland Dreier , Sam Ravnborg , Sergei Trofimovich , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org Michal Marek wrote: > Setting LC_CTYPE=C breaks localized messages in some setups. With only > LC_COLLATE=C and LC_NUMERIC=C, we get almost all we need, except for not > so defined character classes and tolower()/toupper(). The former is not > a big issue, because we can assume that e.g. [:alpha:] will always > include a-zA-Z and we only ever process ASCII input. The latter seems > only affect arch/sh/tools/gen-mach-types, which we can handle separately. > > So after this patch the meaning of ranges like [a-z], the behavior of > sort and join, etc. should be the same everywhere and at the same time > gcc should be able to print localized waring and error messages. > LC_NUMERIC=C might not be necessary, but setting it doesn't hurt. > > Reported-by: Simon Horman > Reported-by: Sergei Trofimovich > Signed-off-by: Michal Marek I checked that this change doesn't affect arch/x86/tools/gen-insn-attr-x86.awk. Tested-by: Masami Hiramatsu Thank you! > --- > > Note: if this still breaks for someone, we will simply set LC_ALL=C. > > Makefile | 3 +-- > arch/sh/tools/Makefile | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index 09a320f..a7b4351 100644 > --- a/Makefile > +++ b/Makefile > @@ -18,10 +18,9 @@ MAKEFLAGS += -rR --no-print-directory > > # Avoid funny character set dependencies > unexport LC_ALL > -LC_CTYPE=C > LC_COLLATE=C > LC_NUMERIC=C > -export LC_CTYPE LC_COLLATE LC_NUMERIC > +export LC_COLLATE LC_NUMERIC > > # We are using a recursive build, so we need to do a little thinking > # to get the ordering right. > diff --git a/arch/sh/tools/Makefile b/arch/sh/tools/Makefile > index 558a56b..2082af1 100644 > --- a/arch/sh/tools/Makefile > +++ b/arch/sh/tools/Makefile > @@ -13,4 +13,4 @@ > include/generated/machtypes.h: $(src)/gen-mach-types $(src)/mach-types > @echo ' Generating $@' > $(Q)mkdir -p $(dir $@) > - $(Q)$(AWK) -f $^ > $@ || { rm -f $@; /bin/false; } > + $(Q)LC_ALL=C $(AWK) -f $^ > $@ || { rm -f $@; /bin/false; } -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754369Ab0AIBIW (ORCPT ); Fri, 8 Jan 2010 20:08:22 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753928Ab0AIBIV (ORCPT ); Fri, 8 Jan 2010 20:08:21 -0500 Received: from mx1.redhat.com ([209.132.183.28]:34586 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753257Ab0AIBIU (ORCPT ); Fri, 8 Jan 2010 20:08:20 -0500 Message-ID: <4B47D6E3.8080300@redhat.com> Date: Fri, 08 Jan 2010 20:07:47 -0500 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.5) Gecko/20091209 Fedora/3.0-3.fc11 Thunderbird/3.0 MIME-Version: 1.0 To: Michal Marek CC: "H. Peter Anvin" , Simon Horman , Roland Dreier , Sam Ravnborg , Sergei Trofimovich , linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org, linux-sh@vger.kernel.org Subject: Re: [PATCH] Makefile: do not override LC_CTYPE References: <20100108115745.GA14758@sepie.suse.cz> <1262952988-16563-1-git-send-email-mmarek@suse.cz> In-Reply-To: <1262952988-16563-1-git-send-email-mmarek@suse.cz> X-Enigmail-Version: 1.0 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Michal Marek wrote: > Setting LC_CTYPE=C breaks localized messages in some setups. With only > LC_COLLATE=C and LC_NUMERIC=C, we get almost all we need, except for not > so defined character classes and tolower()/toupper(). The former is not > a big issue, because we can assume that e.g. [:alpha:] will always > include a-zA-Z and we only ever process ASCII input. The latter seems > only affect arch/sh/tools/gen-mach-types, which we can handle separately. > > So after this patch the meaning of ranges like [a-z], the behavior of > sort and join, etc. should be the same everywhere and at the same time > gcc should be able to print localized waring and error messages. > LC_NUMERIC=C might not be necessary, but setting it doesn't hurt. > > Reported-by: Simon Horman > Reported-by: Sergei Trofimovich > Signed-off-by: Michal Marek I checked that this change doesn't affect arch/x86/tools/gen-insn-attr-x86.awk. Tested-by: Masami Hiramatsu Thank you! > --- > > Note: if this still breaks for someone, we will simply set LC_ALL=C. > > Makefile | 3 +-- > arch/sh/tools/Makefile | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Makefile b/Makefile > index 09a320f..a7b4351 100644 > --- a/Makefile > +++ b/Makefile > @@ -18,10 +18,9 @@ MAKEFLAGS += -rR --no-print-directory > > # Avoid funny character set dependencies > unexport LC_ALL > -LC_CTYPE=C > LC_COLLATE=C > LC_NUMERIC=C > -export LC_CTYPE LC_COLLATE LC_NUMERIC > +export LC_COLLATE LC_NUMERIC > > # We are using a recursive build, so we need to do a little thinking > # to get the ordering right. > diff --git a/arch/sh/tools/Makefile b/arch/sh/tools/Makefile > index 558a56b..2082af1 100644 > --- a/arch/sh/tools/Makefile > +++ b/arch/sh/tools/Makefile > @@ -13,4 +13,4 @@ > include/generated/machtypes.h: $(src)/gen-mach-types $(src)/mach-types > @echo ' Generating $@' > $(Q)mkdir -p $(dir $@) > - $(Q)$(AWK) -f $^ > $@ || { rm -f $@; /bin/false; } > + $(Q)LC_ALL=C $(AWK) -f $^ > $@ || { rm -f $@; /bin/false; } -- Masami Hiramatsu Software Engineer Hitachi Computer Products (America), Inc. Software Solutions Division e-mail: mhiramat@redhat.com