From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 7/9] KVM: PPC: Emulate trap SRR1 flags properly Date: Sun, 10 Jan 2010 14:34:33 +0200 Message-ID: <4B49C959.8040900@redhat.com> References: <1262915889-11526-1-git-send-email-agraf@suse.de> <1262915889-11526-8-git-send-email-agraf@suse.de> <1FB2DDB0-F72E-437C-BEC5-8E1AEE5FBCC7@suse.de> <465359C6-52BD-4227-BEAC-639CDC239964@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Hollis Blanchard , KVM General , kvm-ppc , Benjamin Herrenschmidt To: Alexander Graf Return-path: Received: from mx1.redhat.com ([209.132.183.28]:41152 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752552Ab0AJMfI (ORCPT ); Sun, 10 Jan 2010 07:35:08 -0500 In-Reply-To: <465359C6-52BD-4227-BEAC-639CDC239964@suse.de> Sender: kvm-owner@vger.kernel.org List-ID: On 01/08/2010 09:37 PM, Alexander Graf wrote: > >> Yes, but I'd rather minimize the behavioral changes as long as we can't test it. >> > Right. That's why the semantics of "flags" are Book3S specific right now and as such the comment is correct. > > The behavioral change we need to do later is to take the ESR setting into queue_program, but that should wait until after someone has a board to test things on again ;-). The reminder that we need to do this is hereby archived in the mails :). > What's the conclusion here? Do we need a respin or is this good enough? -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Sun, 10 Jan 2010 12:34:33 +0000 Subject: Re: [PATCH 7/9] KVM: PPC: Emulate trap SRR1 flags properly Message-Id: <4B49C959.8040900@redhat.com> List-Id: References: <1262915889-11526-1-git-send-email-agraf@suse.de> <1262915889-11526-8-git-send-email-agraf@suse.de> <1FB2DDB0-F72E-437C-BEC5-8E1AEE5FBCC7@suse.de> <465359C6-52BD-4227-BEAC-639CDC239964@suse.de> In-Reply-To: <465359C6-52BD-4227-BEAC-639CDC239964@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf Cc: Hollis Blanchard , KVM General , kvm-ppc , Benjamin Herrenschmidt On 01/08/2010 09:37 PM, Alexander Graf wrote: > >> Yes, but I'd rather minimize the behavioral changes as long as we can't test it. >> > Right. That's why the semantics of "flags" are Book3S specific right now and as such the comment is correct. > > The behavioral change we need to do later is to take the ESR setting into queue_program, but that should wait until after someone has a board to test things on again ;-). The reminder that we need to do this is hereby archived in the mails :). > What's the conclusion here? Do we need a respin or is this good enough? -- error compiling committee.c: too many arguments to function