From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752484Ab0ALBiQ (ORCPT ); Mon, 11 Jan 2010 20:38:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751204Ab0ALBiP (ORCPT ); Mon, 11 Jan 2010 20:38:15 -0500 Received: from mga05.intel.com ([192.55.52.89]:53819 "EHLO fmsmga101.fm.intel.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751140Ab0ALBiP (ORCPT ); Mon, 11 Jan 2010 20:38:15 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.49,258,1262592000"; d="scan'208";a="530418752" Message-ID: <4B4BD281.4080009@linux.intel.com> Date: Tue, 12 Jan 2010 02:38:09 +0100 From: Andi Kleen User-Agent: Thunderbird 2.0.0.23 (Windows/20090812) MIME-Version: 1.0 To: KAMEZAWA Hiroyuki CC: Wu Fengguang , "Zheng, Shaohui" , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "y-goto@jp.fujitsu.com" , Dave Hansen , "x86@kernel.org" Subject: Re: [PATCH - resend] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel(v1) References: <20100108124851.GB6153@localhost> <20100111124303.GA21408@localhost> <20100112093031.0fc6877f.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20100112093031.0fc6877f.kamezawa.hiroyu@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Hmmm....could you rewrite /dev/mem to use kernel/resource.c other than > modifing e820 maps. ? Sorry but responding to bug fixes with "could you please rewrite ..." is not considered fair. Shaohui is just trying to fix a bug here, not redesigning a subsystem. > Two reasons. > - e820map is considerted to be stable, read-only after boot. > - We don't need to add more x86 special codes. We need working memory hotadd. -Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail203.messagelabs.com (mail203.messagelabs.com [216.82.254.243]) by kanga.kvack.org (Postfix) with SMTP id 774226B006A for ; Mon, 11 Jan 2010 20:39:26 -0500 (EST) Message-ID: <4B4BD281.4080009@linux.intel.com> Date: Tue, 12 Jan 2010 02:38:09 +0100 From: Andi Kleen MIME-Version: 1.0 Subject: Re: [PATCH - resend] Memory-Hotplug: Fix the bug on interface /dev/mem for 64-bit kernel(v1) References: <20100108124851.GB6153@localhost> <20100111124303.GA21408@localhost> <20100112093031.0fc6877f.kamezawa.hiroyu@jp.fujitsu.com> In-Reply-To: <20100112093031.0fc6877f.kamezawa.hiroyu@jp.fujitsu.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: KAMEZAWA Hiroyuki Cc: Wu Fengguang , "Zheng, Shaohui" , "linux-mm@kvack.org" , "akpm@linux-foundation.org" , "linux-kernel@vger.kernel.org" , "y-goto@jp.fujitsu.com" , Dave Hansen , "x86@kernel.org" List-ID: > Hmmm....could you rewrite /dev/mem to use kernel/resource.c other than > modifing e820 maps. ? Sorry but responding to bug fixes with "could you please rewrite ..." is not considered fair. Shaohui is just trying to fix a bug here, not redesigning a subsystem. > Two reasons. > - e820map is considerted to be stable, read-only after boot. > - We don't need to add more x86 special codes. We need working memory hotadd. -Andi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org