From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [PATCH] Add definitions for current cpu models.. Date: Wed, 20 Jan 2010 08:21:44 -0600 Message-ID: <4B571178.5040409@codemonkey.ws> References: <4B549016.6090501@redhat.com> <4B560A88.9@codemonkey.ws> <20100119200349.GG3204@sequoia.sous-sol.org> <4B563144.9030803@codemonkey.ws> <20100120001501.GJ3204@sequoia.sous-sol.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: john cooper , "Przywara, Andre" , qemu-devel@nongnu.org, KVM list To: Chris Wright Return-path: Received: from qw-out-2122.google.com ([74.125.92.27]:20578 "EHLO qw-out-2122.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751866Ab0ATOVs (ORCPT ); Wed, 20 Jan 2010 09:21:48 -0500 Received: by qw-out-2122.google.com with SMTP id 3so1194725qwe.37 for ; Wed, 20 Jan 2010 06:21:47 -0800 (PST) In-Reply-To: <20100120001501.GJ3204@sequoia.sous-sol.org> Sender: kvm-owner@vger.kernel.org List-ID: On 01/19/2010 06:15 PM, Chris Wright wrote: > * Anthony Liguori (anthony@codemonkey.ws) wrote: > >> On 01/19/2010 02:03 PM, Chris Wright wrote: >> >>> * Anthony Liguori (anthony@codemonkey.ws) wrote: >>> >>> >>>> I'm very much against having -cpu Nehalem. The whole point of this is >>>> to make things easier for a user and for most of the users I've >>>> encountered, -cpu Nehalem is just as obscure as -cpu >>>> qemu64,-sse3,+vmx,... >>>> >>>> >>> What name will these users know? FWIW, it makes sense to me as it is. >>> >> Whatever is in /proc/cpuinfo. >> > That doesn't exactly generalize to families w/ similar cpuid features. > > Intel(R) Xeon(R) {E,L,X}{74,55}** > Intel(R) Core(TM)2 {Duo,Quad,Extreme} ... > Then we should key off of family and model. So -cpu AMD_Family_10h or something like that. At least that is discoverable by a user. Regards, Anthony Liguori