From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 097D3C43613 for ; Fri, 21 Jun 2019 13:47:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C7C9C21537 for ; Fri, 21 Jun 2019 13:47:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=fb.com header.i=@fb.com header.b="KSvIL8FZ"; dkim=pass (1024-bit key) header.d=fb.onmicrosoft.com header.i=@fb.onmicrosoft.com header.b="H7fUKcoB" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726104AbfFUNrH (ORCPT ); Fri, 21 Jun 2019 09:47:07 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:48264 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726010AbfFUNrG (ORCPT ); Fri, 21 Jun 2019 09:47:06 -0400 Received: from pps.filterd (m0044010.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x5LDjBw9025928; Fri, 21 Jun 2019 06:45:11 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-id : content-transfer-encoding : mime-version; s=facebook; bh=uC4Bx9X6fgUoXCX3YCb/E1O6k1iheAK8w4uL3+9K5Zs=; b=KSvIL8FZV0rWLKFOvYNSz4D+qi8b3uwybMeZm3vgwFRDvkNVChtVWUS/tVA8W0zVAjCw Lbavuf6hfx1F0iAA9Eohr/gGDdpNQgCfEwjkmSLV6RQxQaD/KhI9ByuD6DGmTfO8EUFR qZHMuhEkgL4FriwKbmi7k0yTQeMe2R7hDcM= Received: from maileast.thefacebook.com ([163.114.130.16]) by mx0a-00082601.pphosted.com with ESMTP id 2t8qjp1p83-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Fri, 21 Jun 2019 06:45:10 -0700 Received: from ash-exhub103.TheFacebook.com (2620:10d:c0a8:82::c) by ash-exhub202.TheFacebook.com (2620:10d:c0a8:83::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 21 Jun 2019 06:45:04 -0700 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (100.104.31.183) by o365-in.thefacebook.com (100.104.35.174) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 21 Jun 2019 06:45:04 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uC4Bx9X6fgUoXCX3YCb/E1O6k1iheAK8w4uL3+9K5Zs=; b=H7fUKcoBl1sDK6JS6WfQxVydhTCUD/49WPnkbafq9paSu3BD6jzwEXVgLynKb7LgbIp6GdXgKmCg0rz8ZziFBAR1apUazqg90/XkkbSaEFBCbYtB5IsoZB2I0lvVR5qIcb8xUkKEUNPAgNA2T0eo7ihpQFcI0nE9KyByUpVY86U= Received: from MWHPR15MB1165.namprd15.prod.outlook.com (10.175.3.22) by MWHPR15MB1119.namprd15.prod.outlook.com (10.175.8.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.16; Fri, 21 Jun 2019 13:45:03 +0000 Received: from MWHPR15MB1165.namprd15.prod.outlook.com ([fe80::400e:e329:ea98:aa0d]) by MWHPR15MB1165.namprd15.prod.outlook.com ([fe80::400e:e329:ea98:aa0d%6]) with mapi id 15.20.2008.014; Fri, 21 Jun 2019 13:45:03 +0000 From: Song Liu To: "Kirill A. Shutemov" CC: LKML , Linux-MM , "oleg@redhat.com" , "rostedt@goodmis.org" , "mhiramat@kernel.org" , "matthew.wilcox@oracle.com" , "kirill.shutemov@linux.intel.com" , "Kernel Team" Subject: Re: [PATCH v4 5/5] uprobe: collapse THP pmd after removing all uprobes Thread-Topic: [PATCH v4 5/5] uprobe: collapse THP pmd after removing all uprobes Thread-Index: AQHVIhGkBNxZAI1nUkK1d2OfbYvmTqamGxWAgAAIBYCAAAVYgIAAAncA Date: Fri, 21 Jun 2019 13:45:03 +0000 Message-ID: <4B58B3B3-10CB-4593-8BEC-1CEF41F856A1@fb.com> References: <20190613175747.1964753-1-songliubraving@fb.com> <20190613175747.1964753-6-songliubraving@fb.com> <20190621124823.ziyyx3aagnkobs2n@box> <20190621133613.xnzpdlicqvjklrze@box> In-Reply-To: <20190621133613.xnzpdlicqvjklrze@box> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-mailer: Apple Mail (2.3445.104.11) x-originating-ip: [2620:10d:c090:180::1:ed23] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 37eca679-553c-47c9-817d-08d6f64ea98a x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:MWHPR15MB1119; x-ms-traffictypediagnostic: MWHPR15MB1119: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-forefront-prvs: 0075CB064E x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(346002)(376002)(366004)(136003)(39860400002)(396003)(189003)(199004)(66946007)(6506007)(53546011)(2906002)(102836004)(6116002)(6512007)(81166006)(81156014)(8676002)(86362001)(76176011)(68736007)(33656002)(186003)(76116006)(305945005)(66476007)(66446008)(66556008)(64756008)(7736002)(73956011)(256004)(99286004)(5660300002)(53936002)(36756003)(25786009)(316002)(71190400001)(71200400001)(6916009)(478600001)(6486002)(46003)(6246003)(14454004)(229853002)(486006)(50226002)(57306001)(446003)(11346002)(476003)(6436002)(2616005)(54906003)(8936002)(4326008);DIR:OUT;SFP:1102;SCL:1;SRVR:MWHPR15MB1119;H:MWHPR15MB1165.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: fb.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: XWLQkvGs+wUS8MbEqjKrJ2KKkEiGh3RPcMQhzVV/gaBmh6aCxMsKe4ZA+68ysmTuu01CIeukfj2DycjWQnVgE2sj2bJJ0ln02kWI2n+8yVJVXTI2Z9X5GUBL5Kd2hbXSm1z1rZP2fI2XHBRdM9yUj2MejFvigkF5DHjd0U+jerKNHmhwQw7ZJGTKjJPu+Dziv4ju9V8f6Dc24R0OR4ZJcahA1ilv6yOMWJ5h5XPny7oavuzzWg3lNPfxhjC0hMFSBwKOB1QSLOldWcryOjA+jRD8pxuxgcNNz7LJBv3hO/HIYWsb+q0oEJa+uftFhzWo2zqnTMimKCLsW3yvgfobxjlVuf+Dbjm8fUtrlw9WCg/j0YGfGR+NSVeYi4g8wVKWl+h3AJabgPdqnYFzLEXnhfceE6ju6xo39fX10D7jYEA= Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 37eca679-553c-47c9-817d-08d6f64ea98a X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Jun 2019 13:45:03.0471 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: songliubraving@fb.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR15MB1119 X-OriginatorOrg: fb.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-06-21_10:,, signatures=0 X-Proofpoint-Spam-Details: rule=fb_default_notspam policy=fb_default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=741 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1906210115 X-FB-Internal: deliver Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Jun 21, 2019, at 6:36 AM, Kirill A. Shutemov wr= ote: >=20 > On Fri, Jun 21, 2019 at 01:17:05PM +0000, Song Liu wrote: >>=20 >>=20 >>> On Jun 21, 2019, at 5:48 AM, Kirill A. Shutemov = wrote: >>>=20 >>> On Thu, Jun 13, 2019 at 10:57:47AM -0700, Song Liu wrote: >>>> After all uprobes are removed from the huge page (with PTE pgtable), i= t >>>> is possible to collapse the pmd and benefit from THP again. This patch >>>> does the collapse. >>>>=20 >>>> An issue on earlier version was discovered by kbuild test robot. >>>>=20 >>>> Reported-by: kbuild test robot >>>> Signed-off-by: Song Liu >>>> --- >>>> include/linux/huge_mm.h | 7 +++++ >>>> kernel/events/uprobes.c | 5 ++- >>>> mm/huge_memory.c | 69 +++++++++++++++++++++++++++++++++++++++++ >>>=20 >>> I still sync it's duplication of khugepaged functinallity. We need to f= ix >>> khugepaged to handle SCAN_PAGE_COMPOUND and probably refactor the code = to >>> be able to call for collapse of particular range if we have all locks >>> taken (as we do in uprobe case). >>>=20 >>=20 >> I see the point now. I misunderstood it for a while.=20 >>=20 >> If we add this to khugepaged, it will have some conflicts with my other= =20 >> patchset. How about we move the functionality to khugepaged after these >> two sets get in?=20 >=20 > Is the last patch of the patchset essential? I think this part can be don= e > a bit later in a proper way, no? Technically, we need this patch to regroup pmd mapped page, and thus get=20 the performance benefit after the uprobe is detached.=20 On the other hand, if we get the first 4 patches of the this set and the=20 other set in soonish. I will work on improving this patch right after that.= . Thanks, Song=