All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taku Izumi <izumi.taku@jp.fujitsu.com>
To: "Brandeburg, Jesse" <jesse.brandeburg@intel.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"Allan, Bruce W" <bruce.w.allan@intel.com>,
	"David S. Miller" <davem@davemloft.net>,
	"Ronciak, John" <john.ronciak@intel.com>,
	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
	"Waskiewicz Jr, Peter P" <peter.p.waskiewicz.jr@intel.com>,
	Koki Sanagi <sanagi.koki@jp.fujitsu.com>,
	Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>,
	"chavey@google.com" <chavey@google.com>,
	e1000-devel@lists.sourceforge.net
Subject: Re: [PATCH v2 0/3] e1000e,igb,ixgbe: add registers etc. printout code just before resetting adapters
Date: Tue, 26 Jan 2010 19:21:09 +0900	[thread overview]
Message-ID: <4B5EC215.5090509@jp.fujitsu.com> (raw)
In-Reply-To: <alpine.WNT.2.00.1001221345580.6104@jbrandeb-desk1.amr.corp.intel.com>

Hi Jesse,

(2010/01/23 6:54), Brandeburg, Jesse wrote:
> Taku, thanks for these, we are talking the patches over and reviewing
> them.  While I agree with the idea of these patches is good, I still don't
> agree with the default being enabled.  Usually if someone is getting tx
> hangs they are repeatable and we can work with them to get the debug
> turned on.  I DO think it is useful to have the feature available by
> default but NOT enabled.
> 
> If we wanted to enable something by default it might be useful to print
> something that actually draws some conclusions from known failure modes,
> like if TDH!=TDT after some amount of time.  I think one or two lines
> maximum for default printing.
> 
> If you're working in this area I had an idea.  I had wanted to be able to
> print the large amount of ring information (especially in the ixgbe case
> with many rings) to the ftrace buffers in order to not overrun the syslog
> daemon.  Not sure if you're interested in more new features, it certainly
> is separate but related to this patch.

I thought similar things, that is, all information should be dumped to
the private ring buffer to avoid filling syslog up with driver messages.
But I didn't have any good idea to extract information from ring buffers,
so as the first step, I decided to printout it by using printk().
Is there the easy way to extract it from ring buffers?

Best regards,
Taku Izumi


  reply	other threads:[~2010-01-26 10:21 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22  5:45 [PATCH v2 0/3] e1000e,igb,ixgbe: add registers etc. printout code just before resetting adapters Taku Izumi
2010-01-22  5:48 ` [PATCH v2 1/3] e1000e: " Taku Izumi
2010-01-22  8:48   ` Taku Izumi
2010-02-19 19:19   ` Laurent Chavey
2010-01-22  5:49 ` [PATCH v2 2/3] igb: " Taku Izumi
2010-01-22  8:49   ` Taku Izumi
2010-01-22  5:50 ` [PATCH v2 3/3] ixgbe: " Taku Izumi
2010-01-22  8:50   ` Taku Izumi
2010-01-22  6:25 ` [PATCH v2 0/3] e1000e,igb,ixgbe: " Joe Perches
2010-01-22  8:46   ` Taku Izumi
2010-01-22 21:54 ` [PATCH v2 0/3] e1000e, igb, ixgbe: " Brandeburg, Jesse
2010-01-26 10:21   ` Taku Izumi [this message]
2010-02-17 19:10     ` [PATCH v2 0/3] e1000e,igb,ixgbe: " Brandeburg, Jesse
2010-02-17 19:32       ` Brandeburg, Jesse
2010-02-19  8:16       ` Taku Izumi
2010-02-19 11:20         ` Jeff Kirsher
2010-02-24 19:36           ` Laurent Chavey
2010-02-25  0:24             ` Taku Izumi
2010-02-25  0:30           ` Taku Izumi
2010-02-26  9:05       ` [PATCH v2 0/3] e1000e, igb, ixgbe: " Taku Izumi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B5EC215.5090509@jp.fujitsu.com \
    --to=izumi.taku@jp.fujitsu.com \
    --cc=bruce.w.allan@intel.com \
    --cc=chavey@google.com \
    --cc=davem@davemloft.net \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jesse.brandeburg@intel.com \
    --cc=john.ronciak@intel.com \
    --cc=kaneshige.kenji@jp.fujitsu.com \
    --cc=netdev@vger.kernel.org \
    --cc=peter.p.waskiewicz.jr@intel.com \
    --cc=sanagi.koki@jp.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.