From: Jens Lehmann <Jens.Lehmann@web.de>
To: "Shawn O. Pearce" <spearce@spearce.org>,
Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>, Heiko Voigt <hvoigt@hvoigt.net>
Subject: [PATCH] git gui: Quote git path properly when starting another gui in a submodule
Date: Thu, 28 Jan 2010 22:20:39 +0100 [thread overview]
Message-ID: <4B61FFA7.4090205@web.de> (raw)
In-Reply-To: <20100128025647.GB8166@spearce.org>
In do_git_gui() the path of the git executable has to be put into a list,
otherwise calling it will fail when when spaces are present in its path.
Reported-by: Heiko Voigt <hvoigt@hvoigt.net>
Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
---
Am 28.01.2010 03:56, schrieb Shawn O. Pearce:
> Jens Lehmann (2):
> git-gui: Use git diff --submodule when available
> git-gui: Add a special diff popup menu for submodules
Today Heiko reported me this bug I introduced with the second patch.
Sorry for the hassle.
git-gui/git-gui.sh | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index a64191d..840f45c 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh
@@ -2000,7 +2000,7 @@ proc do_git_gui {} {
# -- Always start git gui through whatever we were loaded with. This
# lets us bypass using shell process on Windows systems.
#
- set exe [_which git]
+ set exe [list [_which git]]
if {$exe eq {}} {
error_popup [mc "Couldn't find git gui in PATH"]
} else {
--
1.7.0.rc0.163.g808df.dirty
next prev parent reply other threads:[~2010-01-28 21:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-26 0:05 [PATCH] git-gui: use themed tk widgets with Tk 8.5 Pat Thoyts
2010-01-26 9:17 ` Sverre Rabbelier
2010-01-28 0:51 ` Shawn O. Pearce
2010-01-28 1:45 ` Johannes Schindelin
2010-01-28 1:42 ` Shawn O. Pearce
2010-01-28 2:54 ` Junio C Hamano
2010-01-28 2:56 ` Shawn O. Pearce
2010-01-28 21:20 ` Jens Lehmann [this message]
2010-01-28 23:45 ` [PATCH] git gui: Quote git path properly when starting another gui in a submodule Shawn O. Pearce
2010-02-02 8:25 ` [PATCH] git-gui: use themed tk widgets with Tk 8.5 Johannes Sixt
2010-02-02 21:09 ` Pat Thoyts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B61FFA7.4090205@web.de \
--to=jens.lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=hvoigt@hvoigt.net \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.