From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Garzik Subject: Re: [Patch 1/1] CLD: Introduce the "New CLD" API Date: Sun, 07 Feb 2010 17:26:46 -0500 Message-ID: <4B6F3E26.8000808@garzik.org> References: <20100207121550.7ee94ff6@redhat.com> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :content-type:content-transfer-encoding; bh=1B/NG8Bjty0d7SFccw34BCnkzpuoar728l3lhllB9Ac=; b=WyH4+q38NpHtFgmcFIunqlnUy9m4QGzX8A8BbQNM5cKneqP8wEOJFhosTO/snVp76m 8p8cVe8PSBE45bDwbMwXvvXYcymLNsVoegR4TaHkrslLmtLbaiXsEE53s6RmnGFlZwf4 XBog+IgpkR+Ar/GiymJOZhcatPYYJv1com7N4= In-Reply-To: <20100207121550.7ee94ff6@redhat.com> Sender: hail-devel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Pete Zaitcev Cc: Project Hail List On 02/07/2010 02:15 PM, Pete Zaitcev wrote: > The "traditional" CLD API is too difficult to program. In particular, > switching from a rigid "Group" policy to arbitrary paths in existing > clients in Chunk and tabled turned out to be next to impossible. > The issue is due to the fundamental nature of the API as based on very > fine-grained events. > > So, in the interests of clients, introduce the "new" API. Its basic > definition is in. It presents a filesystem-like interface, > extended with event callbacks for coarse events, such as an end of > CLD session. > > The patch converts all in-tree clients from cldc_xxx to ncld_xxx and > discards some of code that became unused (test/util.c). > > Signed-Off-By: Pete Zaitcev At a quick glance, looks good. A few nits like the "if (log)" stuff and indenting struct field names jump out, but nothing major. I'll give it a thorough review and apply on Monday... Jeff