From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jeff Garzik <jeff@garzik.org>
Subject: Re: [Patch 1/1] CLD: Introduce the "New CLD" API
Date: Mon, 08 Feb 2010 23:55:03 -0500
Message-ID: <4B70EAA7.4060806@garzik.org>
References: <20100207121550.7ee94ff6@redhat.com>	<4B700478.3020305@garzik.org>	<20100208184649.51374774@redhat.com>	<4B70C319.6040005@garzik.org> <20100208191701.6e15b452@redhat.com>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Return-path: <hail-devel-owner@vger.kernel.org>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=gmail.com; s=gamma;
        h=domainkey-signature:received:received:sender:message-id:date:from
         :user-agent:mime-version:to:cc:subject:references:in-reply-to
         :content-type:content-transfer-encoding;
        bh=4B3icV3itmlEMLom/l0sJjlCQBPPSE3CF1VD9ZPnUOA=;
        b=AEnWDj6C4Pi8wlm7Df8MB1bQRfLsSVecvxqLy9qD8Qub9GsjdX9DU87aU6HY9cH73+
         MtCtqT4oVJOkodY1WK0TELJfq0Fg8GeCbK/XK2W3K6Gq+IQ9zniTE4ZKPcpd42fHsEVK
         LZHOMTuQY5rC4uzetIy64g3c3nY42cHkFEeLo=
In-Reply-To: <20100208191701.6e15b452@redhat.com>
Sender: hail-devel-owner@vger.kernel.org
List-ID: <hail-devel.vger.kernel.org>
Content-Type: text/plain; charset="us-ascii"; format="flowed"
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: Project Hail List <hail-devel@vger.kernel.org>

On 02/08/2010 09:17 PM, Pete Zaitcev wrote:
> On Mon, 08 Feb 2010 21:06:17 -0500
> Jeff Garzik<jeff@garzik.org>  wrote:
>
>>> -	if (cldc_getaddr(&host_list, hostb, NULL))
>>> +	if (cldc_getaddr(&host_list, hostb,&ncld_log))
>>>    		return 1001;
>
>> Logging pointer should be supplied by the caller...  that is the larger
>> bug.  Needing a no-op log function is just an indication of that.
>
> I did it before, but then every client, without exception, needed
> to include<stdarg.h>  and provide the log. And what for? This is
> STUPID and proof is in the pudding: your getsrvinfo does not do
> anything of the sort.

Possibly true -- but it is worse to introduce internal inconsistencies. 
  It is far better to remove debugging statements completely than to 
create inconsistent usage.


> Might as well replace cldc_getadd with getsrvinfo
> and then everyone becomes happy.

Seems a good fit :)

	Jeff