All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] SAMSUNG: SMDKC100: Adds ethernet support.
Date: Tue, 09 Feb 2010 21:40:01 -0800	[thread overview]
Message-ID: <4B7246B1.2060406@gmail.com> (raw)
In-Reply-To: <ef0d8a251002092053s67b44c2cvf7c3063925fad36d@mail.gmail.com>

Hi Naveen,

On 2/9/2010 8:53 PM, Naveen Krishna Ch wrote:
> Hi Ben,
>
> I think you wanted me to remove the CONFIG_BOOTP_* macros.
> But the gmail is showing some other code under ur comments.
>
> Any how i wil remove the CONFIG_BOOTP_* macros and submit a
> V2 version of the patch.
>
I don't have a problem with the CONFIG_BOOTP macros as long as you put 
them there intentionally rather than as a cut&paste.  My quarrel was 
with the MAC and IP address assignments.  It looks like you've removed 
those, so it's all OK.

regards,
Ben

  reply	other threads:[~2010-02-10  5:40 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1234>
2010-02-09  9:22 ` [U-Boot] [PATCH 0/3] SAMSUNG: SMDKC100: Add Ethernet support Naveen Krishna Ch
2010-02-09  9:34   ` [U-Boot] [PATCH 1/3] S5PC100: Memory SubSystem Header file, register description(SROMC) Naveen Krishna Ch
2010-02-10  5:48     ` Minkyu Kang
2010-02-10  6:16       ` Naveen Krishna Ch
2010-02-10 10:34         ` Minkyu Kang
2010-02-11  9:10           ` Naveen Krishna Ch
2010-02-09  9:38   ` [U-Boot] [PATCH 2/3] S5PC100: Function to configure the SROMC registers Naveen Krishna Ch
2010-02-10  6:13     ` Minkyu Kang
2010-02-10  6:31       ` Naveen Krishna Ch
2010-02-10  6:52         ` Minkyu Kang
2010-02-10 10:36           ` Minkyu Kang
2010-02-10 11:32             ` Naveen Krishna Ch
2010-02-09  9:38   ` [U-Boot] [PATCH 3/3] SAMSUNG: SMDKC100: Adds ethernet support Naveen Krishna Ch
2010-02-09 14:52     ` Ben Warren
2010-02-10  4:53       ` Naveen Krishna Ch
2010-02-10  5:40         ` Ben Warren [this message]
2010-02-10  3:16   ` [U-Boot] [PATCH 0/3] SAMSUNG: SMDKC100: Add Ethernet support Minkyu Kang
2010-02-10  3:22     ` Naveen Krishna Ch
2010-02-10 12:46 [U-Boot] [PATCH 3/3] SAMSUNG: SMDKC100: Adds ethernet support Naveen Krishna Ch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B7246B1.2060406@gmail.com \
    --to=biggerbadderben@gmail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.