From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NgdDJ-0004NC-QC for qemu-devel@nongnu.org; Sun, 14 Feb 2010 07:04:37 -0500 Received: from [199.232.76.173] (port=43826 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NgdDJ-0004N0-1B for qemu-devel@nongnu.org; Sun, 14 Feb 2010 07:04:37 -0500 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1NgdDI-0004kL-5j for qemu-devel@nongnu.org; Sun, 14 Feb 2010 07:04:36 -0500 Received: from mx1.redhat.com ([209.132.183.28]:43725) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1NgdDH-0004kH-PH for qemu-devel@nongnu.org; Sun, 14 Feb 2010 07:04:36 -0500 Message-ID: <4B77E6CF.7000901@redhat.com> Date: Sun, 14 Feb 2010 13:04:31 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] Give sdl-config higher priority than pkg-config List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: Jacob Meuser , qemu-devel On 02/14/2010 08:23 AM, Blue Swirl wrote: > On OpenBSD, pkg-config sdl --cflags forgets to add -I/usr/local/include > which is needed for iconv.h (included from SDL.h). This makes SDL > detection fail. > > Try sdl-config first, only if it fails try pkg-config. This breaks cross-compilation. I'm CCing the OpenBSD package maintainer so that he can fix it. Upstream SDL has --cflags) echo -I@includedir@/SDL @SDL_CFLAGS@ ;; in sdl-config.in and Cflags: -I${includedir}/SDL @SDL_CFLAGS@ in sdl.pc.in, while OpenBSD has different values, so he modified sdl-config apparently but not sdl.pc.in. Paolo