All of lore.kernel.org
 help / color / mirror / Atom feed
From: TARUISI Hiroaki <taruishi.hiroak@jp.fujitsu.com>
To: kreijack@gmail.com
Cc: linux-btrfs@vger.kernel.org
Subject: Re: [PATCH 1/2 V2] btrfs, a new tool to manage a btrfs filesystem; source code
Date: Thu, 18 Feb 2010 09:54:38 +0900	[thread overview]
Message-ID: <4B7C8FCE.6090706@jp.fujitsu.com> (raw)
In-Reply-To: <201002172102.30645.kreijack@inwind.it>

Hi,
It's a cool utility with tidy source code.
At my first glance, there's typo, a question and an impression.

 - There's no "<source>" in usage of utility.
 - will occupe -> will occupy
   (usage of utility : "btrfs resize")
 - Is specifying a target device of resizing isn't public
   even in your utility?
 - I felt somehow confusing with the short commands.
   It's not easy to associate it from its command.

Regards,
taruisi

(2010/02/18 5:02), Goffredo Baroncelli wrote:
> This is the source code of btrfs.c.
> The main changes from my previous patch are:
> - Rearranged the short command in order to avoid conflicts
> - Renamed the 'create' verb is 'subvolume'
> - Rearranged the parsing code, which now is integrated in the help in order to avoid mismatch
> 
> BR
> G.Baroncelli
> 
 - snip -


      reply	other threads:[~2010-02-18  0:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17 20:02 [PATCH 1/2 V2] btrfs, a new tool to manage a btrfs filesystem; source code Goffredo Baroncelli
2010-02-18  0:54 ` TARUISI Hiroaki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B7C8FCE.6090706@jp.fujitsu.com \
    --to=taruishi.hiroak@jp.fujitsu.com \
    --cc=kreijack@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.