All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <randy.dunlap@oracle.com>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	scsi <linux-scsi@vger.kernel.org>,
	"James E.J. Bottomley" <James.Bottomley@suse.de>
Subject: Re: linux-next: Tree for February 19 (scsi/mpt2sas/raid_class)
Date: Fri, 19 Feb 2010 09:21:50 -0800	[thread overview]
Message-ID: <4B7EC8AE.60200@oracle.com> (raw)
In-Reply-To: <20100219174711.5e7cc7be.sfr@canb.auug.org.au>

On 02/18/10 22:47, Stephen Rothwell wrote:
> Hi all,
> 
> Changes since 20100218:
> 
> 
> The scsi tree lost its build failure.


(caused by a one-line patch to scsi/mpt2sas/Kconfig:
	select RAID_ATTRS
)


When CONFIG_SCSI=m, CONFIG_RAID_ATTRS can still be =y, causing build errors
like:

ERROR: "raid_class_release" [drivers/scsi/mpt2sas/mpt2sas.ko] undefined!
ERROR: "raid_class_attach" [drivers/scsi/mpt2sas/mpt2sas.ko] undefined!

drivers/scsi/built-in.o does contain raid_class_* code (according to 'nm'),
but drivers/built-in.o does not, so I guess that drivers/Makefile:

obj-$(CONFIG_SCSI)		+= scsi/

is preventing drivers/scsi/built-in.o from being added to drivers/built-in.o.

We can:

a/  change drivers/Makefile to say:

obj-y				+= scsi/

(test: that still had a build error:
drivers/built-in.o: In function `raid_match':
raid_class.c:(.text+0x9de7c): undefined reference to `scsi_is_sdev_device'
)

b/  change drivers/scsi/Kconfig to make RAID_ATTRS depend on SCSI, so that raid_class
would be built as a module

That one does work.


Do something else?
Preferences?

-- 
~Randy

  reply	other threads:[~2010-02-19 17:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-19  6:47 linux-next: Tree for February 19 Stephen Rothwell
2010-02-19 17:21 ` Randy Dunlap [this message]
2010-02-22  3:46   ` [PATCH -next] scsi: RAID_ATTRS depends on SCSI Randy Dunlap
2010-03-02 11:26     ` [origin tree build failure] " Ingo Molnar
2010-03-02 23:30       ` Stephen Rothwell
2010-03-03  5:36     ` James Bottomley
2010-03-03  6:17       ` Stephen Rothwell
2010-03-03 16:56       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B7EC8AE.60200@oracle.com \
    --to=randy.dunlap@oracle.com \
    --cc=James.Bottomley@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.