From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [PATCH 08/10] Add -kvm option
Date: Sat, 27 Feb 2010 11:35:06 +0100
Message-ID: <4B88F55A.6040702@web.de>
References: <1267215141-13629-1-git-send-email-glommer@redhat.com> <1267215141-13629-2-git-send-email-glommer@redhat.com> <1267215141-13629-3-git-send-email-glommer@redhat.com> <1267215141-13629-4-git-send-email-glommer@redhat.com> <1267215141-13629-5-git-send-email-glommer@redhat.com> <1267215141-13629-6-git-send-email-glommer@redhat.com> <1267215141-13629-7-git-send-email-glommer@redhat.com> <1267215141-13629-8-git-send-email-glommer@redhat.com> <1267215141-13629-9-git-send-email-glommer@redhat.com>
Mime-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature";
 boundary="------------enig3EB3117DB9766390EF7E770C"
Cc: kvm@vger.kernel.org, mtosatti@redhat.com
To: Glauber Costa <glommer@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from fmmailgate02.web.de ([217.72.192.227]:47398 "EHLO
	fmmailgate02.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754550Ab0B0Kh5 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Sat, 27 Feb 2010 05:37:57 -0500
In-Reply-To: <1267215141-13629-9-git-send-email-glommer@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig3EB3117DB9766390EF7E770C
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable

Glauber Costa wrote:
> This option deprecates --enable-kvm. It is a more flexible option,
> that makes use of qemu-opts, and allow us to pass on options to enable =
or
> disable kernel irqchip, for example.
>=20

=2E..

> diff --git a/qemu-options.hx b/qemu-options.hx
> index 3f49b44..f8fd86d 100644
> --- a/qemu-options.hx
> +++ b/qemu-options.hx
> @@ -1793,10 +1793,17 @@ Set the filename for the BIOS.
>  ETEXI
> =20
>  #ifdef CONFIG_KVM
> -DEF("enable-kvm", 0, QEMU_OPTION_enable_kvm, \
> -    "-enable-kvm     enable KVM full virtualization support\n")
> +HXCOMM Options deprecated by -kvm
> +DEF("enable-kvm", 0, QEMU_OPTION_enable_kvm, "")
> +
> +DEF("kvm", HAS_ARG, QEMU_OPTION_kvm, \
> +    "-kvm enable=3Don|off,irqchip-in-kernel=3Don|off\n" \
> +    "                enable KVM full virtualization support\n")
> +

I would prefer "irqchip=3Dkernel|user" - shorter and even more verbose.

Forgot if that was discussed already: Do we want "pit=3Dkernel|user" as w=
ell?

Jan


--------------enig3EB3117DB9766390EF7E770C
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.9 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iEYEARECAAYFAkuI9VoACgkQitSsb3rl5xRsLgCgmeh5ErqEZXZ05LAOETJmtoEw
5oMAoI0ltOBrUfWZPLo4xaBy2gLbFwoy
=E297
-----END PGP SIGNATURE-----

--------------enig3EB3117DB9766390EF7E770C--