All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Daney <ddaney@caviumnetworks.com>
To: Yang Shi <yang.shi@windriver.com>, ralf@linux-mips.org
Cc: f.fainelli@gmail.com, linux-mips@linux-mips.org
Subject: Re: [PATCH 2/3] MIPS: Octeon: Remove redundant declaration of octeon_reserve32_memory
Date: Wed, 03 Mar 2010 10:25:49 -0800	[thread overview]
Message-ID: <4B8EA9AD.8070106@caviumnetworks.com> (raw)
In-Reply-To: <50e36e8549769a26986f99a23772d23fd039c230.1267604875.git.yang.shi@windriver.com>

On 03/03/2010 12:43 AM, Yang Shi wrote:
> In Octeon's setup.c, octeon_reserve32_memory is defined, so remove the
> redundant extern declaration of this variable.
>
> Signed-off-by: Yang Shi<yang.shi@windriver.com>

Acked-by: David Daney <ddaney@caviumnetworks.com>

This looks good to me.  Thanks,
David Daney

> ---
>   arch/mips/cavium-octeon/setup.c |    3 ---
>   1 files changed, 0 insertions(+), 3 deletions(-)
>
> diff --git a/arch/mips/cavium-octeon/setup.c b/arch/mips/cavium-octeon/setup.c
> index 4eaa35f..8309d68 100644
> --- a/arch/mips/cavium-octeon/setup.c
> +++ b/arch/mips/cavium-octeon/setup.c
> @@ -45,9 +45,6 @@ extern struct plat_smp_ops octeon_smp_ops;
>   extern void pci_console_init(const char *arg);
>   #endif
>
> -#ifdef CONFIG_CAVIUM_RESERVE32
> -extern uint64_t octeon_reserve32_memory;
> -#endif
>   static unsigned long long MAX_MEMORY = 512ull<<  20;
>
>   struct octeon_boot_descriptor *octeon_boot_desc_ptr;

  parent reply	other threads:[~2010-03-03 18:25 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-03  8:43 [V2] Octeon: Several misc fixes Yang Shi
2010-03-03  8:43 ` [PATCH 1/3] MIPS: Octeon: Remove superfluous on_each_cpu parameter Yang Shi
2010-03-03  8:43   ` [PATCH 2/3] MIPS: Octeon: Remove redundant declaration of octeon_reserve32_memory Yang Shi
2010-03-03  8:43     ` [PATCH 3/3] MIPS: Octeon: Add add_wired_entry decralation in header file Yang Shi
2010-03-03 18:24       ` David Daney
2010-03-09 14:16         ` Ralf Baechle
2010-03-03 18:25     ` David Daney [this message]
2010-03-11  0:52       ` [PATCH 2/3] MIPS: Octeon: Remove redundant declaration of octeon_reserve32_memory Ralf Baechle
2010-03-03 17:53   ` [PATCH 1/3] MIPS: Octeon: Remove superfluous on_each_cpu parameter David Daney
2010-03-04  2:08     ` Yang Shi
  -- strict thread matches above, loose matches on Subject: below --
2010-03-03  7:26 Octeon: Several misc fixes Yang Shi
2010-03-03  7:26 ` [PATCH 1/3] MIPS: Octeon: Remove superfluous on_each_cpu parameter Yang Shi
2010-03-03  7:26   ` [PATCH 2/3] MIPS: Octeon: Remove redundant declaration of octeon_reserve32_memory Yang Shi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B8EA9AD.8070106@caviumnetworks.com \
    --to=ddaney@caviumnetworks.com \
    --cc=f.fainelli@gmail.com \
    --cc=linux-mips@linux-mips.org \
    --cc=ralf@linux-mips.org \
    --cc=yang.shi@windriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.