All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Anton Vorontsov <avorontsov@ru.mvista.com>
Cc: Sergei Shtylyov <sshtylyov@mvista.com>,
	linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/11] ahci: Move generic code into libahci
Date: Wed, 03 Mar 2010 13:43:49 -0500	[thread overview]
Message-ID: <4B8EADE5.5010109@pobox.com> (raw)
In-Reply-To: <20100303171747.GI12362@oksana.dev.rtsoft.ru>

On 03/03/2010 12:17 PM, Anton Vorontsov wrote:
> This patch should contain no functional changes, just moves code
> around.

Excellent!  I like how this patch series is split up.  You've precisely 
what you needed to do here -- major code movement should avoid any 
changes outside the minimum required to build this patch.

Others should follow your example :)


> diff --git a/drivers/ata/libahci.c b/drivers/ata/libahci.c
> new file mode 100644
> index 0000000..3ec32ee
> --- /dev/null
> +++ b/drivers/ata/libahci.c
> @@ -0,0 +1,2059 @@
> +/*
> + *  ahci.c - AHCI SATA low-level routines

this should reflect new filename



> diff --git a/drivers/ata/libahci.h b/drivers/ata/libahci.h
> new file mode 100644
> index 0000000..60bce4e
> --- /dev/null
> +++ b/drivers/ata/libahci.h
> @@ -0,0 +1,330 @@
> +/*
> + *  ahci.c - AHCI SATA low-level routines

Ditto.

Note that my preference for header file name would be ahci.h rather than 
libahci.h, to reflect that it includes generic AHCI hardware definitions 
as well as libahci structures and function prototypes.


  parent reply	other threads:[~2010-03-03 18:49 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-03 17:17 [PATCH 0/11] ahci: Add support for non-PCI devices Anton Vorontsov
2010-03-03 17:17 ` [PATCH 01/11] ahci: Get rid of host->iomap usage Anton Vorontsov
2010-03-03 18:45   ` Jeff Garzik
2010-03-03 18:49     ` Jeff Garzik
2010-03-03 17:17 ` [PATCH 02/11] ahci: Factor out PCI specifics from ahci_save_initial_config() Anton Vorontsov
2010-03-03 17:17 ` [PATCH 03/11] ahci: Get rid of pci_dev argument in ahci_save_initial_config() Anton Vorontsov
2010-03-03 17:17 ` [PATCH 04/11] ahci: Factor out PCI specifics from ahci_reset_controller() Anton Vorontsov
2010-03-03 17:17 ` [PATCH 05/11] ahci: Get rid of pci_dev argument in ahci_port_init() Anton Vorontsov
2010-03-03 17:17 ` [PATCH 06/11] ahci: Factor out PCI specifics from ahci_init_controller() Anton Vorontsov
2010-03-03 17:17 ` [PATCH 07/11] ahci: Factor out PCI specifics from ahci_print_info() Anton Vorontsov
2010-03-03 17:17 ` [PATCH 08/11] ahci: Introduce ahci_set_em_messages() Anton Vorontsov
2010-03-03 20:52   ` Jeff Garzik
2010-03-03 17:17 ` [PATCH 09/11] ahci: Move generic code into libahci Anton Vorontsov
2010-03-03 17:33   ` Sergei Shtylyov
2010-03-03 17:45     ` Anton Vorontsov
2010-03-03 18:43   ` Jeff Garzik [this message]
2010-03-03 21:58     ` Mark Lord
2010-03-03 17:17 ` [PATCH 10/11] ahci: Export generic AHCI symbols, turn libahci into a separate module Anton Vorontsov
2010-03-03 17:53   ` Sergei Shtylyov
2010-03-03 18:08     ` Anton Vorontsov
2010-03-03 18:14       ` Anton Vorontsov
2010-03-03 18:34         ` Jeff Garzik
2010-03-03 18:42           ` Anton Vorontsov
2010-03-03 17:17 ` [PATCH 11/11] ahci: Add platform driver Anton Vorontsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4B8EADE5.5010109@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=avorontsov@ru.mvista.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sshtylyov@mvista.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.