From: Miguel Aguilar <miguel.aguilar@ridgerun.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: davinci-linux-open-source@linux.davincidsp.com, nsekhar@ti.com,
alsa-devel@alsa-project.org
Subject: Re: [PATCH 3/5] ASoC: DaVinci: CQ93VC Voice Codec
Date: Mon, 08 Mar 2010 11:26:47 -0600 [thread overview]
Message-ID: <4B953357.9080904@ridgerun.com> (raw)
In-Reply-To: <20100125111104.GC22909@sirena.org.uk>
Hi Mark,
What is the status of this patch series?, I'm still missing the change pointed
below for third patch.
Regards,
Miguel Aguilar
Mark Brown wrote:
> On Thu, Jan 21, 2010 at 11:41:00AM -0600, miguel.aguilar@ridgerun.com wrote:
>
>> +static __init int cq93vc_codec_probe(struct platform_device *pdev)
>> +{
>
> ...
>
>> + cq93vc_codec = codec;
>> +
>> + ret = snd_soc_register_dai(&cq93vc_dai);
>> + if (ret != 0) {
>> + dev_err(davinci_vc->dev, "could register dai\n");
>> + goto fail1;
>> + }
>> + return 0;
>
> There should also be a snd_soc_register_codec() before this, and
> similarly on the remove. Otherwise this looks good.
next prev parent reply other threads:[~2010-03-08 17:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 17:41 [PATCH 3/5] ASoC: DaVinci: CQ93VC Voice Codec miguel.aguilar
2010-01-25 11:11 ` Mark Brown
2010-03-08 17:26 ` Miguel Aguilar [this message]
2010-03-08 17:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B953357.9080904@ridgerun.com \
--to=miguel.aguilar@ridgerun.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=davinci-linux-open-source@linux.davincidsp.com \
--cc=nsekhar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.