From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932718Ab0CJSgM (ORCPT ); Wed, 10 Mar 2010 13:36:12 -0500 Received: from einhorn.in-berlin.de ([192.109.42.8]:59144 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755122Ab0CJSgJ (ORCPT ); Wed, 10 Mar 2010 13:36:09 -0500 X-Envelope-From: stefanr@s5r6.in-berlin.de Message-ID: <4B97E68E.2070205@s5r6.in-berlin.de> Date: Wed, 10 Mar 2010 19:35:58 +0100 From: Stefan Richter User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.8.1.23) Gecko/20100102 SeaMonkey/1.1.18 MIME-Version: 1.0 To: Joe Perches CC: Greg KH , LKML , devel , Andy Whitcroft Subject: Re: Tuxradar patching article and [PATCH] scripts/cvt_kernel_style.pl References: <1268177526.1545.62.camel@Joe-Laptop.home> <20100309234152.GA30270@suse.de> <1268179619.1545.95.camel@Joe-Laptop.home> In-Reply-To: <1268179619.1545.95.camel@Joe-Laptop.home> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Joe Perches wrote: > On Tue, 2010-03-09 at 15:41 -0800, Greg KH wrote: >> It's better that you look at the code yourself, and make the change that >> looks correct, which is not always the same thing that an automated tool >> would do. > > I disagree. > > It's better to make changes that _actually are_ correct. > People also neglect to see and convert a lot of things. There is no correct and incorrect style. There is only - accepted/ not accepted style, - good/ bad style. -- Stefan Richter -=====-==-=- --== -=-=- http://arcgraph.de/sr/