From: Jim Lin <jilin@nvidia.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] usb: tegra: Fix PHY configuration for Tegra 3
Date: Sat, 15 Feb 2014 12:47:45 +0800 [thread overview]
Message-ID: <4B9C9637D5087840A465BDCB251780E9E3373B1191@HKMAIL02.nvidia.com> (raw)
In-Reply-To: <952d768092b4ac9912931e9e65e3adc6@agner.ch>
________________________________________
???: Stefan Agner [stefan at agner.ch]
????: 2014?2?15? ?? 06:52
???: u-boot at lists.denx.de; Jim Lin; Tom Warren; swarren at wwwdotorg.org; sjg at chromium.org; dev at lynxeye.de
??: Re: [PATCH v2] usb: tegra: Fix PHY configuration for Tegra 3
Am 2014-02-14 23:45, schrieb Stefan Agner:
> /* Select ULPI parallel interface */
> - clrsetbits_le32(&usbctlr->port_sc1, PTS_MASK, PTS_ULPI << PTS_SHIFT);
> + if (!controller->has_hostpc) {
> + clrsetbits_le32(&usbctlr->port_sc1, PTS_MASK,
> + PTS_ULPI << PTS_SHIFT);
> + else
> + clrsetbits_le32(&usbctlr->hostpc1_devlc, PTS_MASK,
> + PTS_ULPI << PTS_SHIFT);
>
> /* enable ULPI transceiver */
> setbits_le32(&usbctlr->susp_ctrl, ULPI_PHY_ENB);
Ok, just noticed that we need to address the different USBD register
layout on Tegra 2 here too.
Furthermore, the code does not compile with Tegra 2 header file since
the hostpc1_devlc field is missing there. The function
ehci_get_port_speed uses a define and some calculation to work around
this issue. Another solution would be to create a dummy field in the
Tegra 2 USB register header file... Any thoughts on that?
[Jim} Try use
usbctlr->usb_cmd + HOSTPC1_DEVLC
instead of usbctlr->hostpc1_devlc
--nvpublic
next prev parent reply other threads:[~2014-02-15 4:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 22:45 [U-Boot] [PATCH v2] usb: tegra: Fix PHY configuration for Tegra 3 Stefan Agner
2014-02-14 22:52 ` Stefan Agner
2014-02-15 4:47 ` Jim Lin [this message]
2014-02-15 6:38 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4B9C9637D5087840A465BDCB251780E9E3373B1191@HKMAIL02.nvidia.com \
--to=jilin@nvidia.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.