From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <tj@kernel.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
pchen@nvidia.com, kernel-bugzilla.20.drkshadow@spamgourmet.com
Subject: Re: [PATCH #upstream-fixes 2/3] ahci: clean up board IDs
Date: Wed, 17 Mar 2010 19:04:08 -0400 [thread overview]
Message-ID: <4BA15FE8.9010609@garzik.org> (raw)
In-Reply-To: <4BA15EA8.8000707@kernel.org>
On 03/17/2010 06:58 PM, Tejun Heo wrote:
> Hello,
>
> On 03/18/2010 02:44 AM, Jeff Garzik wrote:
>> It actually makes merging a lot more difficult, considering that libahci
>> -- which includes large amounts of ahci code movement -- was committed
>> to #upstream a week before this patch was posted.
>>
>> Because of libahci changes, I think patch #2 (this patch) and patch #3
>> are more appropriate for #upstream.
>>
>> The "(pdev->vendor != PCI_VENDOR_ID_NVIDIA)" may be overly broad, but
>> it's not wrong for 2.6.34, IMO.
>
> Hmmm... the actual fix is in #3. I'll prep separate patches for
> upstream and upstream-fixes.
What does it fix, specifically? AFAICS, the patch changes the AHCI
state from
no FPDMA AA for all NVIDIA
to
some FPDMA AA for NVIDIA
thus the current state of the code is not broken and in need of fixing,
but merely overly conservative. Am I missing something?
Jeff
next prev parent reply other threads:[~2010-03-17 23:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-11 2:37 [PATCH #upstream-fixes 1/3] ahci: add missing nv IDs Tejun Heo
2010-03-11 2:39 ` [PATCH #upstream-fixes 2/3] ahci: clean up board IDs Tejun Heo
2010-03-11 2:40 ` [PATCH #upstream-fixes 3/3] ahci: implement AHCI_HFLAG_NO_FPDMA_AA and update NV quirks Tejun Heo
2010-03-12 0:08 ` Robert Hancock
2010-03-12 1:16 ` Tejun Heo
2010-03-17 17:44 ` [PATCH #upstream-fixes 2/3] ahci: clean up board IDs Jeff Garzik
2010-03-17 22:58 ` Tejun Heo
2010-03-17 23:04 ` Jeff Garzik [this message]
2010-03-18 0:02 ` Tejun Heo
2010-03-17 17:47 ` [PATCH #upstream-fixes 1/3] ahci: add missing nv IDs Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA15FE8.9010609@garzik.org \
--to=jeff@garzik.org \
--cc=kernel-bugzilla.20.drkshadow@spamgourmet.com \
--cc=linux-ide@vger.kernel.org \
--cc=pchen@nvidia.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.