[Qemu-devel] git head broken? (x86 softmmu w/o kvm)

[Qemu-devel] git head broken? (x86 softmmu w/o kvm)

[Juergen Lock]

Hi!

 I just wanted to make another FreeBSD qemu git head snaphot port update,
and found both i386-softmmu and x86_64-softmmu no longer boot, they seem
to hang early in the bios before it prints anything, last tb seems to be
this loop:

----------------
IN: 
0x00000000000f1b8e:  mov    0xf81a0,%ecx
0x00000000000f1b94:  cmp    %ecx,%eax
0x00000000000f1b96:  jne    0xf1b8e

OUT: [size=184]
0x4000e440:  mov    $0xf81a0,%ebp
0x4000e445:  mov    %rbp,%rsi
0x4000e448:  mov    %rbp,%rdi
0x4000e44b:  shr    $0x7,%rsi
0x4000e44f:  and    $0xfffffffffffff003,%rdi
0x4000e456:  and    $0x1fe0,%esi
0x4000e45c:  lea    0x4f8(%rsi,%r14,1),%rsi
0x4000e464:  cmp    (%rsi),%rdi
0x4000e467:  mov    %rbp,%rdi
0x4000e46a:  je     0x4000e477
0x4000e46c:  xor    %esi,%esi
0x4000e46e:  callq  0x51fd30
0x4000e473:  mov    %eax,%ebp
0x4000e475:  jmp    0x4000e47d
0x4000e477:  add    0x18(%rsi),%rdi
0x4000e47b:  mov    (%rdi),%ebp
0x4000e47d:  mov    %ebp,%ebp
0x4000e47f:  mov    %rbp,%rbx
0x4000e482:  mov    (%r14),%r12
0x4000e485:  mov    %rbx,%r13
0x4000e488:  sub    %rbx,%r12
0x4000e48b:  mov    %r12,%rbx
0x4000e48e:  mov    %ebx,%ebx
0x4000e490:  mov    $0x10,%r15d
0x4000e496:  mov    %r15d,0xa0(%r14)
0x4000e49d:  mov    %r13,0x90(%r14)
0x4000e4a4:  mov    %r12,0x98(%r14)
0x4000e4ab:  mov    %rbp,0x8(%r14)
0x4000e4af:  test   %rbx,%rbx
0x4000e4b2:  jne    0x4000e4d8
0x4000e4b8:  jmpq   0x4000e4bd
0x4000e4bd:  mov    $0xf1b98,%ebp
0x4000e4c2:  mov    %rbp,0x80(%r14)
0x4000e4c9:  mov    $0x802c05c80,%rax
0x4000e4d3:  jmpq   0xb65b8e
0x4000e4d8:  jmpq   0x4000e4dd
0x4000e4dd:  mov    $0xf1b8e,%ebp
0x4000e4e2:  mov    %rbp,0x80(%r14)
0x4000e4e9:  mov    $0x802c05c81,%rax
0x4000e4f3:  jmpq   0xb65b8e

 Is 0xf81a0 an io port or how is it supposed to change?  And, can
anyone reproduce this on Linux?  As I said this is without kvm...

 Thanx! :)
	Juergen

[Qemu-devel] Re: git head broken? (x86 softmmu w/o kvm)

[Juergen Lock]

On Mon, Mar 22, 2010 at 10:25:24PM +0100, Juergen Lock wrote:
> Hi!
> 
>  I just wanted to make another FreeBSD qemu git head snaphot port update,
> and found both i386-softmmu and x86_64-softmmu no longer boot, they seem
> to hang early in the bios before it prints anything, last tb seems to be
> this loop:
> 
> ----------------
> IN: 
> 0x00000000000f1b8e:  mov    0xf81a0,%ecx
> 0x00000000000f1b94:  cmp    %ecx,%eax
> 0x00000000000f1b96:  jne    0xf1b8e
> 
> OUT: [size=184]
> 0x4000e440:  mov    $0xf81a0,%ebp
> 0x4000e445:  mov    %rbp,%rsi
> 0x4000e448:  mov    %rbp,%rdi
> 0x4000e44b:  shr    $0x7,%rsi
> 0x4000e44f:  and    $0xfffffffffffff003,%rdi
> 0x4000e456:  and    $0x1fe0,%esi
> 0x4000e45c:  lea    0x4f8(%rsi,%r14,1),%rsi
> 0x4000e464:  cmp    (%rsi),%rdi
> 0x4000e467:  mov    %rbp,%rdi
> 0x4000e46a:  je     0x4000e477
> 0x4000e46c:  xor    %esi,%esi
> 0x4000e46e:  callq  0x51fd30
> 0x4000e473:  mov    %eax,%ebp
> 0x4000e475:  jmp    0x4000e47d
> 0x4000e477:  add    0x18(%rsi),%rdi
> 0x4000e47b:  mov    (%rdi),%ebp
> 0x4000e47d:  mov    %ebp,%ebp
> 0x4000e47f:  mov    %rbp,%rbx
> 0x4000e482:  mov    (%r14),%r12
> 0x4000e485:  mov    %rbx,%r13
> 0x4000e488:  sub    %rbx,%r12
> 0x4000e48b:  mov    %r12,%rbx
> 0x4000e48e:  mov    %ebx,%ebx
> 0x4000e490:  mov    $0x10,%r15d
> 0x4000e496:  mov    %r15d,0xa0(%r14)
> 0x4000e49d:  mov    %r13,0x90(%r14)
> 0x4000e4a4:  mov    %r12,0x98(%r14)
> 0x4000e4ab:  mov    %rbp,0x8(%r14)
> 0x4000e4af:  test   %rbx,%rbx
> 0x4000e4b2:  jne    0x4000e4d8
> 0x4000e4b8:  jmpq   0x4000e4bd
> 0x4000e4bd:  mov    $0xf1b98,%ebp
> 0x4000e4c2:  mov    %rbp,0x80(%r14)
> 0x4000e4c9:  mov    $0x802c05c80,%rax
> 0x4000e4d3:  jmpq   0xb65b8e
> 0x4000e4d8:  jmpq   0x4000e4dd
> 0x4000e4dd:  mov    $0xf1b8e,%ebp
> 0x4000e4e2:  mov    %rbp,0x80(%r14)
> 0x4000e4e9:  mov    $0x802c05c81,%rax
> 0x4000e4f3:  jmpq   0xb65b8e
> 
>  Is 0xf81a0 an io port or how is it supposed to change?  And, can
> anyone reproduce this on Linux?  As I said this is without kvm...

..and in case its supposed to be changed by an irq I just tried
	-d in_asm,out_asm,int
and saw none listed.  I've put the qemu.log here:
	http://people.freebsd.org/~nox/qemu/qemu.log.gz

 TIA,
	Juergen

Re: [Qemu-devel] git head broken? (x86 softmmu w/o kvm)

[Aurelien Jarno]

On Mon, Mar 22, 2010 at 10:25:24PM +0100, Juergen Lock wrote:
> Hi!
> 
>  I just wanted to make another FreeBSD qemu git head snaphot port update,
> and found both i386-softmmu and x86_64-softmmu no longer boot, they seem
> to hang early in the bios before it prints anything, last tb seems to be
> this loop:
> 

A quick bisect revealed it has been broken by this patch:

commit 952760bb7bce7fbfe0afcf04fee268745f297b87
Author: Blue Swirl <blauwirbel@gmail.com>
Date:   Sun Mar 21 19:47:15 2010 +0000

    Compile pci_host only once

    Convert pci_host_conf_register_mmio_noswap(x) to
    pci_host_conf_register_mmio(x, 0).

    Convert pci_host_conf_register_mmio(x) to
    pci_host_conf_register_mmio(x, 1) for big endian hosts, all cases
    happen to be BE.

    Signed-off-by: Blue Swirl <blauwirbel@gmail.com>


-- 
Aurelien Jarno	                        GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

Re: [Qemu-devel] git head broken? (x86 softmmu w/o kvm)

[Aurelien Jarno]

On Tue, Mar 23, 2010 at 03:27:26AM +0100, Aurelien Jarno wrote:
> On Mon, Mar 22, 2010 at 10:25:24PM +0100, Juergen Lock wrote:
> > Hi!
> > 
> >  I just wanted to make another FreeBSD qemu git head snaphot port update,
> > and found both i386-softmmu and x86_64-softmmu no longer boot, they seem
> > to hang early in the bios before it prints anything, last tb seems to be
> > this loop:
> > 
> 
> A quick bisect revealed it has been broken by this patch:
> 

I have just pushed a patch to fix the problem.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

Re: [Qemu-devel] git head broken? (x86 softmmu w/o kvm)

[Markus Armbruster]

Aurelien Jarno <aurelien@aurel32.net> writes:

> On Tue, Mar 23, 2010 at 03:27:26AM +0100, Aurelien Jarno wrote:
>> On Mon, Mar 22, 2010 at 10:25:24PM +0100, Juergen Lock wrote:
>> > Hi!
>> > 
>> >  I just wanted to make another FreeBSD qemu git head snaphot port update,
>> > and found both i386-softmmu and x86_64-softmmu no longer boot, they seem
>> > to hang early in the bios before it prints anything, last tb seems to be
>> > this loop:
>> > 
>> 
>> A quick bisect revealed it has been broken by this patch:
>> 
>
> I have just pushed a patch to fix the problem.

Thanks.

I can't see the offending on the mailing list.  Was it committed without
review?

Re: [Qemu-devel] git head broken? (x86 softmmu w/o kvm)

[Aurelien Jarno]

Markus Armbruster a écrit :
> Aurelien Jarno <aurelien@aurel32.net> writes:
> 
>> On Tue, Mar 23, 2010 at 03:27:26AM +0100, Aurelien Jarno wrote:
>>> On Mon, Mar 22, 2010 at 10:25:24PM +0100, Juergen Lock wrote:
>>>> Hi!
>>>>
>>>>  I just wanted to make another FreeBSD qemu git head snaphot port update,
>>>> and found both i386-softmmu and x86_64-softmmu no longer boot, they seem
>>>> to hang early in the bios before it prints anything, last tb seems to be
>>>> this loop:
>>>>
>>> A quick bisect revealed it has been broken by this patch:
>>>
>> I have just pushed a patch to fix the problem.
> 
> Thanks.
> 
> I can't see the offending on the mailing list.  Was it committed without
> review?
> 

Yes

-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net

[Qemu-devel] Re: git head broken? (x86 softmmu w/o kvm)

[Paolo Bonzini]

On 03/23/2010 11:06 AM, Markus Armbruster wrote:
> Aurelien Jarno<aurelien@aurel32.net>  writes:
>
>> On Tue, Mar 23, 2010 at 03:27:26AM +0100, Aurelien Jarno wrote:
>>> On Mon, Mar 22, 2010 at 10:25:24PM +0100, Juergen Lock wrote:
>>>> Hi!
>>>>
>>>>   I just wanted to make another FreeBSD qemu git head snaphot port update,
>>>> and found both i386-softmmu and x86_64-softmmu no longer boot, they seem
>>>> to hang early in the bios before it prints anything, last tb seems to be
>>>> this loop:
>>>>
>>>
>>> A quick bisect revealed it has been broken by this patch:
>>>
>>
>> I have just pushed a patch to fix the problem.
>
> Thanks.
>
> I can't see the offending on the mailing list.  Was it committed without
> review?

It was actually a series of 20-odd patches.  Patches with a laudable 
goal, but also some of them quite risky.

Paolo

Re: [Qemu-devel] git head broken? (x86 softmmu w/o kvm)

[Blue Swirl]

On 3/23/10, Aurelien Jarno <aurelien@aurel32.net> wrote:
> On Tue, Mar 23, 2010 at 03:27:26AM +0100, Aurelien Jarno wrote:
>  > On Mon, Mar 22, 2010 at 10:25:24PM +0100, Juergen Lock wrote:
>  > > Hi!
>  > >
>  > >  I just wanted to make another FreeBSD qemu git head snaphot port update,
>  > > and found both i386-softmmu and x86_64-softmmu no longer boot, they seem
>  > > to hang early in the bios before it prints anything, last tb seems to be
>  > > this loop:
>  > >
>  >
>  > A quick bisect revealed it has been broken by this patch:
>  >
>
>
> I have just pushed a patch to fix the problem.

Thanks, sorry for the trouble.

Re: [Qemu-devel] git head broken? (x86 softmmu w/o kvm)

[Anthony Liguori]

Hi,

On 03/23/2010 02:24 PM, Blue Swirl wrote:
> On 3/23/10, Aurelien Jarno<aurelien@aurel32.net>  wrote:
>    
>> On Tue, Mar 23, 2010 at 03:27:26AM +0100, Aurelien Jarno wrote:
>>   >  On Mon, Mar 22, 2010 at 10:25:24PM +0100, Juergen Lock wrote:
>>   >  >  Hi!
>>   >  >
>>   >  >   I just wanted to make another FreeBSD qemu git head snaphot port update,
>>   >  >  and found both i386-softmmu and x86_64-softmmu no longer boot, they seem
>>   >  >  to hang early in the bios before it prints anything, last tb seems to be
>>   >  >  this loop:
>>   >  >
>>   >
>>   >  A quick bisect revealed it has been broken by this patch:
>>   >
>>
>>
>> I have just pushed a patch to fix the problem.
>>      
> Thanks, sorry for the trouble.
>    

It would be nice to send a series like this to the list first in the 
future to give people a heads up.  It's a useful set of clean-ups but 
it's nice to give people a chance to provide input.

Regards,

Anthony Liguori

Re: [Qemu-devel] git head broken? (x86 softmmu w/o kvm)

[Markus Armbruster]

Anthony Liguori <anthony@codemonkey.ws> writes:

> Hi,
>
> On 03/23/2010 02:24 PM, Blue Swirl wrote:
>> On 3/23/10, Aurelien Jarno<aurelien@aurel32.net>  wrote:
>>    
>>> On Tue, Mar 23, 2010 at 03:27:26AM +0100, Aurelien Jarno wrote:
>>>   >  On Mon, Mar 22, 2010 at 10:25:24PM +0100, Juergen Lock wrote:
>>>   >  >  Hi!
>>>   >  >
>>>   >  >   I just wanted to make another FreeBSD qemu git head snaphot port update,
>>>   >  >  and found both i386-softmmu and x86_64-softmmu no longer boot, they seem
>>>   >  >  to hang early in the bios before it prints anything, last tb seems to be
>>>   >  >  this loop:
>>>   >  >
>>>   >
>>>   >  A quick bisect revealed it has been broken by this patch:
>>>   >
>>>
>>>
>>> I have just pushed a patch to fix the problem.
>>>      
>> Thanks, sorry for the trouble.
>>    
>
> It would be nice to send a series like this to the list first in the
> future to give people a heads up.  It's a useful set of clean-ups but
> it's nice to give people a chance to provide input.

It's not merely "nice", it's how we work.  It's a far more important and
useful rule than where to put the curlies and such.

And yes, the patch series is good stuff.