From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@web.de>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm <kvm@vger.kernel.org>
Subject: Re: [PATCH] KVM: x86: Fix TSS size check for 16-bit tasks
Date: Tue, 23 Mar 2010 14:25:33 +0200 [thread overview]
Message-ID: <4BA8B33D.7040903@redhat.com> (raw)
In-Reply-To: <4BA8A432.7070303@web.de>
On 03/23/2010 01:21 PM, Jan Kiszka wrote:
>
>> A 44-byte TSS has a limit of 43 (just like a 4GB segment has a limit of
>> 0xffffffff), so there is an off-by-one here.
>>
>>
> Right - you just found an (harmless) off-by-one in our legacy OS as well
> (I blindly copied its limit).
>
>
It's a very common error.
--
error compiling committee.c: too many arguments to function
next prev parent reply other threads:[~2010-03-23 12:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-22 10:29 [PATCH] KVM: x86: Fix TSS size check for 16-bit tasks Jan Kiszka
2010-03-23 10:25 ` Avi Kivity
2010-03-23 10:42 ` Avi Kivity
2010-03-23 12:14 ` Jan Kiszka
2010-03-23 11:21 ` Jan Kiszka
2010-03-23 12:25 ` Avi Kivity [this message]
2010-03-23 11:25 ` [PATCH v2] " Jan Kiszka
2010-03-23 12:35 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4BA8B33D.7040903@redhat.com \
--to=avi@redhat.com \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.