From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jason Wang Subject: Re: [Autotest] [PATCH] Monotonic time test: Don't force static compilation of time_test Date: Wed, 24 Mar 2010 09:16:30 +0800 Message-ID: <4BA967EE.1080900@redhat.com> References: <1269368002-12652-1-git-send-email-lmr@redhat.com> <33307c791003231125s770c8034t2859fde10c10cf5f@mail.gmail.com> <6ac58f4f1003231356v7abdeb93v2810e56cb3877749@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Martin Bligh , autotest@test.kernel.org, Michael Davidson , kvm@vger.kernel.org To: Lucas Meneghel Rodrigues Return-path: Received: from mx1.redhat.com ([209.132.183.28]:13662 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753036Ab0CXBQj (ORCPT ); Tue, 23 Mar 2010 21:16:39 -0400 In-Reply-To: <6ac58f4f1003231356v7abdeb93v2810e56cb3877749@mail.gmail.com> Sender: kvm-owner@vger.kernel.org List-ID: Lucas Meneghel Rodrigues wrote: > On Tue, Mar 23, 2010 at 3:25 PM, Martin Bligh wrote: > >> +cc:md (he wrote the test). >> >> On Tue, Mar 23, 2010 at 11:13 AM, Lucas Meneghel Rodrigues >> wrote: >> >>> The Makefile for the monotonic_test C program forces static >>> compilation of the object files. Since we are compiling the >>> code already, not having a static binary doesn't make much >>> of a difference on the systems we are running this test. >>> >>> As the static compilation might fail in some boxes, just remove >>> this constraint from the Makefile. >>> >> I presume this was to fix some Google interdependency. >> Is it actually breaking something? If not, seems safer to leave it? >> If so, we'll have to fix one end or the other ;-) >> > > Yes, I can't get a static build on a Fedora 13 box by no means, that's > why I looked into what was going wrong and cooked this patch. If > someone has any suggestions of what I need to do to work around this, > let me know. > > I met the same problem and there should be no difference when not using the static build. >>> Signed-off-by: Lucas Meneghel Rodrigues >>> --- >>> client/tests/monotonic_time/src/Makefile | 1 - >>> 1 files changed, 0 insertions(+), 1 deletions(-) >>> >>> diff --git a/client/tests/monotonic_time/src/Makefile b/client/tests/monotonic_time/src/Makefile >>> index 56aa7b6..2121ec4 100644 >>> --- a/client/tests/monotonic_time/src/Makefile >>> +++ b/client/tests/monotonic_time/src/Makefile >>> @@ -1,7 +1,6 @@ >>> CC= cc >>> >>> CFLAGS= -O -std=gnu99 -Wall >>> -LDFLAGS=-static >>> LIBS= -lpthread -lrt >>> >>> PROG= time_test >>> -- >>> 1.6.6.1 >>> >>> _______________________________________________ >>> Autotest mailing list >>> Autotest@test.kernel.org >>> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest >>> >>> >> _______________________________________________ >> Autotest mailing list >> Autotest@test.kernel.org >> http://test.kernel.org/cgi-bin/mailman/listinfo/autotest >> >> > > > >