All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rick Jones <rick.jones2@hp.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Changli Gao <xiaosuo@gmail.com>,
	Tom Herbert <therbert@google.com>,
	davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] rfs: Receive Flow Steering
Date: Fri, 02 Apr 2010 10:01:42 -0700	[thread overview]
Message-ID: <4BB622F6.10606@hp.com> (raw)
In-Reply-To: <1270193393.1936.52.camel@edumazet-laptop>

Eric Dumazet wrote:
> 
> Your claim of RPS being not good for applications is wrong, our test
> results show an improvement as is. Maybe your applications dont scale,
> because of bad habits, or collidings heuristics, I dont know.

The progression in HP-UX was IPS (10.20) (aka RPS) then TOPS (11.0) (aka RFS). 
We found that IPS was great for single-flow-per-thread-of-execution stuff and 
that TOPS was better for multiple-flow-per-thread-of-execution stuff.  It was 
long enough ago now that I can safely say for one system-level benchmark not 
known to be a "networking" benchmark, and without a massive kernel component, 
TOPS was a 10% win.  Not too shabby.

It wasn't that IPS wasn't good in its context - just that TOPS was even better.

We also preferred the concept of the scheduler giving networking clues as to 
where to process an application's packets rather than networking trying to tell 
the scheduler.  There was some discussion of out of order worries, but we were 
willing to trust to the basic soundness of the scheduler - if it was moving 
threads around willy nilly at a rate able to cause big packet reordering it had 
fundamental problems that would have to be addressed anyway.  And while it may 
be incindiary to point this out :)  I suspect (without concrete data :) that 
bonding mode 0 is a much, Much, MUCH larger source of out-of-order traffic than 
any plausible scheduler thrashing.

happy benchmarking,

rick jones

  parent reply	other threads:[~2010-04-02 17:01 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-02  3:59 [PATCH] rfs: Receive Flow Steering Tom Herbert
2010-04-02  5:04 ` Changli Gao
2010-04-02  7:29   ` Eric Dumazet
2010-04-02 10:58     ` Changli Gao
2010-04-02 12:01       ` Eric Dumazet
2010-04-02 13:45         ` Changli Gao
2010-04-02 17:01     ` Rick Jones [this message]
     [not found]       ` <g2i65634d661004021045uff7c0e25ge7dfd17929bc9ee9@mail.gmail.com>
2010-04-02 18:25         ` Rick Jones
2010-04-08  1:37           ` Changli Gao
2010-04-02  7:58 ` Eric Dumazet
2010-04-02  8:35 ` Eric Dumazet
2010-04-02 12:37   ` Eric Dumazet
2010-04-02 16:28     ` Eric Dumazet
2010-04-02 19:43       ` Eric Dumazet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4BB622F6.10606@hp.com \
    --to=rick.jones2@hp.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=therbert@google.com \
    --cc=xiaosuo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.