From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O2ohf-0005NN-3W for qemu-devel@nongnu.org; Fri, 16 Apr 2010 12:47:39 -0400 Received: from [140.186.70.92] (port=41081 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O2ohX-0003uC-3o for qemu-devel@nongnu.org; Fri, 16 Apr 2010 12:47:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O2gbO-0006vO-CU for qemu-devel@nongnu.org; Fri, 16 Apr 2010 04:12:28 -0400 Received: from mx1.redhat.com ([209.132.183.28]:17050) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O2gbM-0006uq-PR for qemu-devel@nongnu.org; Fri, 16 Apr 2010 04:08:38 -0400 Message-ID: <4BC81AFE.8010008@redhat.com> Date: Fri, 16 Apr 2010 10:08:30 +0200 From: Gerd Hoffmann MIME-Version: 1.0 Subject: Re: [Qemu-devel] [RfC PATCH 08/11] spice: add qxl device References: <1271238922-10008-1-git-send-email-kraxel@redhat.com> <1271238922-10008-9-git-send-email-kraxel@redhat.com> <476F9623-727A-4E64-9FFD-FBF423C68006@suse.de> In-Reply-To: <476F9623-727A-4E64-9FFD-FBF423C68006@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alexander Graf Cc: qemu-devel@nongnu.org On 04/15/10 00:21, Alexander Graf wrote: > > On 14.04.2010, at 11:55, Gerd Hoffmann wrote: > >> >> +static inline void atomic_or(uint32_t *var, uint32_t add) >> +{ >> + __asm__ __volatile__ ("lock; orl %1, %0" : "+m" (*var) : "r" (add) : "memory"); > > I hope this is going away? I don't see why QXL should be coupled to x86 host and guest only. Spice on !x86 (especially big endian boxes) isn't going to fly at the moment for a number of reasons. That is considered a bug though and we want fix it long-term. There is nothing fundamental which prevents qxl and spice from being used on -- say -- ppc. cheers, Gerd