From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1O2h7h-0003mw-9X
	for qemu-devel@nongnu.org; Fri, 16 Apr 2010 04:42:01 -0400
Received: from [140.186.70.92] (port=35917 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1O2h7B-0006MK-Mo
	for qemu-devel@nongnu.org; Fri, 16 Apr 2010 04:42:00 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1O2h6j-0007sB-8U
	for qemu-devel@nongnu.org; Fri, 16 Apr 2010 04:41:28 -0400
Received: from mx1.redhat.com ([209.132.183.28]:39472)
	by eggs.gnu.org with esmtp (Exim 4.69)
	(envelope-from <kraxel@redhat.com>) id 1O2h6j-0007rf-0l
	for qemu-devel@nongnu.org; Fri, 16 Apr 2010 04:41:01 -0400
Message-ID: <4BC8228D.10909@redhat.com>
Date: Fri, 16 Apr 2010 10:40:45 +0200
From: Gerd Hoffmann <kraxel@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RfC PATCH 11/11] spice: add audio
References: <1271238922-10008-1-git-send-email-kraxel@redhat.com>
	<1271238922-10008-12-git-send-email-kraxel@redhat.com>
	<alpine.LNX.2.00.1004150046460.1599@linmac>
In-Reply-To: <alpine.LNX.2.00.1004150046460.1599@linmac>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: malc <av1474@comtv.ru>
Cc: qemu-devel@nongnu.org

On 04/14/10 22:51, malc wrote:
> On Wed, 14 Apr 2010, Gerd Hoffmann wrote:
>
> The code does not follow neither audio(which is passable should it be
> internally consistent) nor general QEMU code style (braces missing)

Will add the missing braces.

>> +static void *spice_audio_init(void)
>> +{
>> +    if (!using_spice)
>> +        return NULL;
>> +    return qemu_malloc(42);
>
> Eh? The HGttG references should at least be given an explanation in
> the comments.

Just need return something non-NULL here to indicate success.
Also wanted to check how carefully the reviewers are looking ;)

> c. I have a really hard time following what rt clock (regardless
>     of monotonicity is doing here at all)

Accept audio data with the correct rate.  When sending directly to the 
audio device the host hardware controls this.  Spice sends the audio 
data off to the network, so this doesn't work.  The math used by spice 
here looks like a old version of the noaudio code for rate control (/me 
inherited that code so I don't know for sure), which makes sense to me.

cheers,
   Gerd