From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH RFC v2 3/6] KVM: introduce a wrapper function to copy dirty bitmaps to user space Date: Fri, 23 Apr 2010 13:26:06 +0300 Message-ID: <4BD175BE.7040307@redhat.com> References: <20100420195349.dab60b1d.yoshikawa.takuya@oss.ntt.co.jp> <20100420195913.ac44281c.yoshikawa.takuya@oss.ntt.co.jp> <4BCEDD89.10705@redhat.com> <4BD00F64.4020405@oss.ntt.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Cc: mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, fernando-gVGce1chcLdL9jVzuh4AOg@public.gmane.org To: Takuya Yoshikawa Return-path: In-Reply-To: <4BD00F64.4020405-gVGce1chcLdL9jVzuh4AOg@public.gmane.org> Sender: kvm-ppc-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: kvm.vger.kernel.org On 04/22/2010 11:57 AM, Takuya Yoshikawa wrote: > > And about x86_32 copy_in_user(). > > They are using copy_user_generic() which is implemented only for 64bit. > > So I'll show them current copy_from_user() and copy_to_user() version and > see their response. > > If rejected, though I hope not, please give me another option, OK? > If we can justify it, I doubt it will be rejected, but in case it does, we'll work something out. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Fri, 23 Apr 2010 10:26:06 +0000 Subject: Re: [PATCH RFC v2 3/6] KVM: introduce a wrapper function to copy Message-Id: <4BD175BE.7040307@redhat.com> List-Id: References: <20100420195349.dab60b1d.yoshikawa.takuya@oss.ntt.co.jp> <20100420195913.ac44281c.yoshikawa.takuya@oss.ntt.co.jp> <4BCEDD89.10705@redhat.com> <4BD00F64.4020405@oss.ntt.co.jp> In-Reply-To: <4BD00F64.4020405-gVGce1chcLdL9jVzuh4AOg@public.gmane.org> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Takuya Yoshikawa Cc: mtosatti-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ia64-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, kvm-ppc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, fernando-gVGce1chcLdL9jVzuh4AOg@public.gmane.org On 04/22/2010 11:57 AM, Takuya Yoshikawa wrote: > > And about x86_32 copy_in_user(). > > They are using copy_user_generic() which is implemented only for 64bit. > > So I'll show them current copy_from_user() and copy_to_user() version and > see their response. > > If rejected, though I hope not, please give me another option, OK? > If we can justify it, I doubt it will be rejected, but in case it does, we'll work something out. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Date: Fri, 23 Apr 2010 10:26:06 +0000 Subject: Re: [PATCH RFC v2 3/6] KVM: introduce a wrapper function to copy Message-Id: <4BD175BE.7040307@redhat.com> List-Id: References: <20100420195913.ac44281c.yoshikawa.takuya@oss.ntt.co.jp> In-Reply-To: <20100420195913.ac44281c.yoshikawa.takuya@oss.ntt.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kvm-ia64@vger.kernel.org On 04/22/2010 11:57 AM, Takuya Yoshikawa wrote: > > And about x86_32 copy_in_user(). > > They are using copy_user_generic() which is implemented only for 64bit. > > So I'll show them current copy_from_user() and copy_to_user() version and > see their response. > > If rejected, though I hope not, please give me another option, OK? > If we can justify it, I doubt it will be rejected, but in case it does, we'll work something out. -- Do not meddle in the internals of kernels, for they are subtle and quick to panic.