All of lore.kernel.org
 help / color / mirror / Atom feed
From: mike@compulab.co.il (Mike Rapoport)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/5] [ARM] usb/host/ohci-pxa27x: make PXA310 USB OTG port work in host mode.
Date: Sun, 13 Jun 2010 09:57:38 +0300	[thread overview]
Message-ID: <4C148162.2020507@compulab.co.il> (raw)
In-Reply-To: <AANLkTilUt8D7B3UF_j1wOvsnXTVQyioofwMEikScdLOn@mail.gmail.com>

Eric Miao wrote:
> On Wed, Jun 2, 2010 at 3:40 PM, Igor Grinberg <grinberg@compulab.co.il> wrote:
>> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
>> Signed-off-by: Mike Rapoport <mike@compulab.co.il>
>> ---
>>  arch/arm/mach-pxa/include/mach/ohci.h     |    3 +
>>  arch/arm/mach-pxa/include/mach/regs-u2d.h |    2 +
>>  drivers/usb/host/ohci-pxa27x.c            |  183 +++++++++++++++++++++++++++++
> 
> My feeling is on pxa310, the OTG/ULPI is actually closer to the UDC, so
> generally, I'd really like to see minimum change to ohci.

There are certain registers set up that should be done in order to 
enable the pxa310 otg port in the host mode. I agree that most of them 
should be done in the UDC driver, but since there's no UDC driver at all 
for pxa310, the most logical place for those register set ups would be 
pxa ohci glue driver.

-- 
Sincerely yours,
Mike.

  parent reply	other threads:[~2010-06-13  6:57 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-02  7:40 [PATCH 0/5] Enable pxa310 usb otg port host mode Igor Grinberg
2010-06-02  7:40 ` [PATCH 1/5] usb/otg/ulpi: extend the generic ulpi driver Igor Grinberg
2010-06-02  7:40   ` [PATCH 2/5] usb/otg/ulpi: add support for SMSC USB3319 ulpi phy Igor Grinberg
2010-06-02  7:40     ` [PATCH 3/5] [ARM] pxa: add PXA310 specific ULPI implementation Igor Grinberg
2010-06-02  7:40       ` [PATCH 4/5] [ARM] usb/host/ohci-pxa27x: make PXA310 USB OTG port work in host mode Igor Grinberg
2010-06-02  7:40         ` [PATCH 5/5] [ARM] pxa/cm-x300: enable USB host port 2 on CM-X300 with PXA310 cpu Igor Grinberg
2010-06-12 11:48         ` [PATCH 4/5] [ARM] usb/host/ohci-pxa27x: make PXA310 USB OTG port work in host mode Eric Miao
2010-06-12 14:24           ` David Brownell
2010-06-13  6:57           ` Mike Rapoport [this message]
2010-06-13  7:04             ` Eric Miao
2010-06-13  7:06               ` Mike Rapoport
2010-06-12  9:35   ` [PATCH 1/5] usb/otg/ulpi: extend the generic ulpi driver Eric Miao
2010-06-12 17:34     ` David Brownell
2010-06-15 14:47     ` Igor Grinberg
2010-08-13 10:21   ` [PATCH] ARM: imx: fix build failure concerning otg/ulpi Uwe Kleine-König
2010-08-13 10:21     ` Uwe Kleine-König
2010-08-13 10:54     ` Sergei Shtylyov
2010-08-13 10:54       ` Sergei Shtylyov
2010-08-13 12:06       ` [PATCH v2] " Uwe Kleine-König
2010-08-13 12:06         ` Uwe Kleine-König
2010-08-15  6:05         ` Igor Grinberg
2010-08-15  6:05           ` Igor Grinberg
2010-08-16  4:53           ` Uwe Kleine-König
2010-08-16  4:53             ` Uwe Kleine-König
2010-08-16  6:09             ` Igor Grinberg
2010-08-16  6:09               ` Igor Grinberg
2010-08-22  7:24               ` Igor Grinberg
2010-08-22  7:24                 ` Igor Grinberg
2010-08-22 17:10                 ` Greg KH
2010-08-22 17:10                   ` Greg KH
2010-06-02  8:29 ` [PATCH 0/5] Enable pxa310 usb otg port host mode Eric Miao
2010-06-06  6:15   ` Igor Grinberg
2010-06-09 11:49 ` Mike Rapoport
2010-06-09 12:43   ` Eric Miao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C148162.2020507@compulab.co.il \
    --to=mike@compulab.co.il \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.