From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 5/24] Introduce vmcs12: a VMCS structure for L1 Date: Mon, 14 Jun 2010 15:35:38 +0300 Message-ID: <4C16221A.30104@redhat.com> References: <1276431753-nyh@il.ibm.com> <201006131225.o5DCP79H012922@rice.haifa.ibm.com> <4C15E95D.9000300@redhat.com> <20100614084943.GA26938@fermat.math.technion.ac.il> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org To: "Nadav Har'El" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:53340 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752234Ab0FNMf4 (ORCPT ); Mon, 14 Jun 2010 08:35:56 -0400 In-Reply-To: <20100614084943.GA26938@fermat.math.technion.ac.il> Sender: kvm-owner@vger.kernel.org List-ID: On 06/14/2010 11:49 AM, Nadav Har'El wrote: > On Mon, Jun 14, 2010, Avi Kivity wrote about "Re: [PATCH 5/24] Introduce vmcs12: a VMCS structure for L1": > >> On 06/13/2010 03:25 PM, Nadav Har'El wrote: >> >>> +#define VMCS12_REVISION 0x11e57ed0 >>> >>> >> Where did this number come from? It's not from real hardware, yes? >> > Basically, we are presenting emulated VMX for the L1 guest, complete with > its own VMCS structure. This structure needs to have some VMCS revision id, > which should be an arbitrary number that we invent - it is not related to any > revision id that any real hardware uses. If you look closely, you can see that > the number I used is leetspeak for "Nested0" ;-) > Will have to brush up on my leetspeak, I see. > As you can see in the following patches, MSR_IA32_VMX_BASIC will return this > arbitrary VMCS revision id, and and VMPTRLD will verify that the VMCS region > that L1 is trying to load contains this revision id. > Ok good, I was worried this was a real hardware ID. -- error compiling committee.c: too many arguments to function