From: Avi Kivity <avi@redhat.com>
To: Wei Yongjun <yjwei@cn.fujitsu.com>
Cc: Marcelo Tosatti <mtosatti@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH] KVM: x86 emulator: fix group3 instruction decoding
Date: Sun, 20 Jun 2010 11:24:53 +0300 [thread overview]
Message-ID: <4C1DD055.2000603@redhat.com> (raw)
In-Reply-To: <4C1AC31E.6010900@cn.fujitsu.com>
On 06/18/2010 03:51 AM, Wei Yongjun wrote:
>
>> On 06/17/2010 12:33 PM, Wei Yongjun wrote:
>>
>>> Group 3 instruction with ModRM reg field as 001 is
>>> defined as test instruction under AMD arch, and
>>> emulate_grp3() is ready for emulate it, so fix the
>>> decoding.
>>>
>>>
>>>
>> Strange but true.
>>
>> Did you encounter any situation which actually needed this, or did you
>> find this by code inspection?
>>
> Just found it by source review, looks strange, so...
>
Well, the emulator usually puts me to sleep, so good catch. Applied the
patch, thanks.
--
error compiling committee.c: too many arguments to function
prev parent reply other threads:[~2010-06-20 8:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-15 1:00 [PATCH] KVM: x86 emulator: fix pusha instruction emulation Wei Yongjun
2010-06-15 1:03 ` [PATCHv2] " Wei Yongjun
2010-06-15 2:10 ` [PATCH] test: add test for pusha and popa instructions Wei Yongjun
2010-06-20 8:29 ` Avi Kivity
2010-06-21 2:48 ` Wei Yongjun
2010-06-21 13:15 ` Avi Kivity
2010-06-15 11:00 ` [PATCHv2] KVM: x86 emulator: fix pusha instruction emulation Avi Kivity
2010-06-16 14:09 ` [PATCH] " Marcelo Tosatti
2010-06-17 9:33 ` [PATCH] KVM: x86 emulator: fix group3 instruction decoding Wei Yongjun
2010-06-17 12:00 ` Avi Kivity
2010-06-18 0:51 ` Wei Yongjun
2010-06-20 8:24 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C1DD055.2000603@redhat.com \
--to=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=mtosatti@redhat.com \
--cc=yjwei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.