All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ryan Mallon <ryan@bluewatersys.com>
To: Anton Vorontsov <cbouatmailru@gmail.com>
Cc: mike@compulab.co.il, linux-kernel@vger.kernel.org,
	vilensky@compulab.co.il, mike.rapoport@gmail.com
Subject: Re: [PATCH] ds2782: Fix ds2782_get_capacity return value
Date: Mon, 21 Jun 2010 09:35:09 +1200	[thread overview]
Message-ID: <4C1E898D.8010902@bluewatersys.com> (raw)
In-Reply-To: <1276562699-4933-1-git-send-email-ryan@bluewatersys.com>

On 06/15/2010 12:44 PM, Ryan Mallon wrote:
> The ds2782_get_capacity function should return 0 on success, not the
> capacity value.
> 
> Signed-off-by: Ryan Mallon <ryan@bluewatersys.com>
> ---
>  drivers/power/ds2782_battery.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/power/ds2782_battery.c b/drivers/power/ds2782_battery.c
> index d762a0c..2afbeec 100644
> --- a/drivers/power/ds2782_battery.c
> +++ b/drivers/power/ds2782_battery.c
> @@ -163,7 +163,7 @@ static int ds2782_get_capacity(struct ds278x_info *info, int *capacity)
>  	if (err)
>  		return err;
>  	*capacity = raw;
> -	return raw;
> +	return 0;
>  }
>  
>  static int ds2786_get_current(struct ds278x_info *info, int *current_uA)

Ping, Anton?

~Ryan

-- 
Bluewater Systems Ltd - ARM Technology Solution Centre

Ryan Mallon         		5 Amuri Park, 404 Barbadoes St
ryan@bluewatersys.com         	PO Box 13 889, Christchurch 8013
http://www.bluewatersys.com	New Zealand
Phone: +64 3 3779127		Freecall: Australia 1800 148 751
Fax:   +64 3 3779135			  USA 1800 261 2934

  reply	other threads:[~2010-06-20 21:35 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-15  0:44 [PATCH] ds2782: Fix ds2782_get_capacity return value Ryan Mallon
2010-06-20 21:35 ` Ryan Mallon [this message]
2010-06-21 15:15   ` Anton Vorontsov
2010-06-22  9:03   ` CoffBeta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4C1E898D.8010902@bluewatersys.com \
    --to=ryan@bluewatersys.com \
    --cc=cbouatmailru@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.rapoport@gmail.com \
    --cc=mike@compulab.co.il \
    --cc=vilensky@compulab.co.il \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.