From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <galak@kernel.crashing.org>
Received: from nommos.sslcatacombnetworking.com
	(nommos.sslcatacombnetworking.com [67.18.224.114])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by ozlabs.org (Postfix) with ESMTP id 6B809DDDF5
	for <linuxppc-dev@ozlabs.org>; Wed, 14 Feb 2007 09:14:21 +1100 (EST)
In-Reply-To: <45D22C38.10803@freescale.com>
References: <11710513671236-git-send-email-timur@freescale.com>	<45CCDEFB.5050504@ru.mvista.com>
	<45CCDFBC.1090104@freescale.com>	<45CCE07F.9040107@ru.mvista.com>
	<45D1F46C.4050901@freescale.com>	<5B1BBAE9-00FC-454B-8855-7D362DF59850@kernel.crashing.org>	<45D1F92B.3000000@freescale.com>	<774F090A-27E6-4271-ABFE-FBFA7855D5AD@kernel.crashing.org>
	<45D21688.8090009@freescale.com> <45D22C38.10803@freescale.com>
Mime-Version: 1.0 (Apple Message framework v752.2)
Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed
Message-Id: <4C265640-16EB-441F-A668-71963D84C67A@kernel.crashing.org>
From: Kumar Gala <galak@kernel.crashing.org>
Subject: Re: [PATCH] Check mac-address first in fsl_soc.c
Date: Tue, 13 Feb 2007 16:14:20 -0600
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.ozlabs.org>
List-Unsubscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=unsubscribe>
List-Archive: <http://ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@ozlabs.org?subject=help>
List-Subscribe: <https://ozlabs.org/mailman/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@ozlabs.org?subject=subscribe>


On Feb 13, 2007, at 3:23 PM, Timur Tabi wrote:

> Timur Tabi wrote:
>> I just had an idea.  The mac-address change should really be  
>> extended to all OF-enabled Ethernet drivers.  How about I put  
>> get_mac_address() in arch/powerpc/kernel/prom.c, right after  
>> get_property(), instead of making it an inline function just for  
>> fsl_soc.c?
>
> Hmmm... if I do that, then get_mac_address() is no longer an init- 
> only function.  That probably is a good thing, because then device  
> trees can call it when they're loaded.  In that case, should I make  
> null_mac_address[] static again?
>
> And what about the name?  Should I call it of_get_mac_address()?   
> Plain old "get_mac_address" sounds like a namespace collision  
> waiting to happen.


of_get_mac_address() seems reasonable, you can always stick it in asm- 
powerpc/prom.h

- k