From: "Justin P. Mattock" <justinmattock@gmail.com>
To: David Howells <dhowells@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org,
lenb@kernel.org
Subject: Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set but not used
Date: Wed, 30 Jun 2010 06:21:58 -0700 [thread overview]
Message-ID: <4C2B44F6.7000808@gmail.com> (raw)
In-Reply-To: <25800.1277889215@redhat.com>
On 06/30/2010 02:13 AM, David Howells wrote:
> Justin P. Mattock<justinmattock@gmail.com> wrote:
>
>> if (!ACPI_FAILURE(status)) {
>> - int ret;
>>
>> - ret = sysfs_create_link(&dev->kobj,&acpi_dev->dev.kobj,
>> + fn = sysfs_create_link(&dev->kobj,&acpi_dev->dev.kobj,
>> "firmware_node");
>> - ret = sysfs_create_link(&acpi_dev->dev.kobj,&dev->kobj,
>> + pn = sysfs_create_link(&acpi_dev->dev.kobj,&dev->kobj,
>> "physical_node");
>> + if (fn) {
>
> That new if-statement still needs indenting one more tab stop. It's indented
> the same as the previous if-statement, but is actually in the body of that
> previous if-statement.
>
> The body of the second if-statement should be indented one tab beyond the if,
> and else/else-if statements and the final closing brace should be indented
> level with the if:
>
> if (...) {
> body;
> } else if (...) {
> body;
> } else {
> body;
> }
>
> so that they line up vertically.
Thanks for the info on this, I really appreciate it. I'll look at this
today, and resend.
>
>> + dev_warn(dev, "dev:%p Failed to create firmware_node: %d\n",
>> + acpi_dev, fn);
>
> The "dev:%p " seems like it ought to be superfluous if you're using
> dev_warn(), and certainly, returning the pointer isn't really useful, I
> suspect.
>
I kept receiving an new warning for using acpi_dev the %p was the only
option I saw in the Documentation that worked
> However, at this point you have two device struct pointers: dev and
> &acip_dev->dev, so printing them both is may be good. Perhaps something like:
>
> + dev_warn(&acpi_dev->dev,
> + "Failed to create firmware_node link to %s %s: %d\n",
> + dev_driver_string(dev), dev_name(dev), fn);
>
> David
>
o.k. I'll look at this today, and see if I can find/locate the device
name and string for these.
Justin P. Mattock
next prev parent reply other threads:[~2010-06-30 13:21 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-27 6:47 [PATCH 0/5] Fix gcc 4.6.0 set but unused variable warnings Justin P. Mattock
2010-06-27 6:47 ` [PATCH 1/5]security:key.c Fix warning: variable 'key' set but not used Justin P. Mattock
2010-06-28 13:05 ` [PATCH] KEYS: Use the variable 'key' in keyctl_describe_key() David Howells
2010-06-28 23:01 ` [Keyrings] " James Morris
2010-06-27 6:47 ` [PATCH 2/5]security:ebitmap.c Fix warning: variable 'e_sft' set but not used Justin P. Mattock
2010-06-27 6:47 ` [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' " Justin P. Mattock
2010-06-27 6:47 ` [PATCH 4/5]block:cryptoloop Fix warning: variable 'cipher' " Justin P. Mattock
2010-06-27 6:47 ` [PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp->msgq_txseq' may be undefined Justin P. Mattock
2010-06-27 7:31 ` Gustavo F. Padovan
2010-06-28 12:57 ` [PATCH] Bluetooth: Fix abuse of the preincrement operator David Howells
2010-06-28 13:12 ` Gustavo F. Padovan
2010-06-30 20:10 ` David Miller
2010-06-28 17:44 ` Justin P. Mattock
2010-06-28 12:38 ` [PATCH 1/5]security:key.c Fix warning: variable 'key' set but not used David Howells
2010-06-28 17:48 ` Justin P. Mattock
2010-06-28 12:44 ` [PATCH 2/5]security:ebitmap.c Fix warning: variable 'e_sft' " David Howells
2010-06-28 17:49 ` Justin P. Mattock
2010-06-28 12:48 ` [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' " David Howells
2010-06-28 17:52 ` Justin P. Mattock
2010-06-28 18:47 ` David Howells
2010-06-28 19:03 ` Justin P. Mattock
2010-06-29 3:23 ` Justin P. Mattock
2010-06-29 15:47 ` David Howells
2010-06-29 17:14 ` Justin P. Mattock
2010-06-29 21:53 ` Justin P. Mattock
2010-06-30 9:13 ` David Howells
2010-06-30 13:21 ` Justin P. Mattock [this message]
2010-06-30 19:47 ` Justin P. Mattock
2010-07-01 9:31 ` David Howells
2010-07-01 13:41 ` Justin P. Mattock
2010-07-01 20:01 ` Justin P. Mattock
2010-07-02 0:10 ` David Howells
2010-07-02 0:59 ` Justin P. Mattock
2010-06-28 19:08 ` Justin P. Mattock
2010-06-28 12:49 ` [PATCH 4/5]block:cryptoloop Fix warning: variable 'cipher' " David Howells
2010-06-28 12:52 ` [PATCH 5/5]bluetooth:hci_bcsp Fix operation on 'bcsp->msgq_txseq' may be undefined David Howells
2010-06-28 13:02 ` Bernd Petrovitsch
2010-06-28 17:56 ` Justin P. Mattock
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C2B44F6.7000808@gmail.com \
--to=justinmattock@gmail.com \
--cc=dhowells@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.