From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Justin P. Mattock" Subject: Re: [PATCH 3/5]acpi:glue.c Fix warning: variable 'ret' set but not used Date: Wed, 30 Jun 2010 12:47:21 -0700 Message-ID: <4C2B9F49.8090304@gmail.com> References: <4C2A6B6C.1000306@gmail.com> <4C29674C.9070503@gmail.com> <4C28E14D.5050701@gmail.com> <1277621246-10960-4-git-send-email-justinmattock@gmail.com> <1277621246-10960-1-git-send-email-justinmattock@gmail.com> <7214.1277729293@redhat.com> <8066.1277750854@redhat.com> <22319.1277826461@redhat.com> <25800.1277889215@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mail-pw0-f46.google.com ([209.85.160.46]:50508 "EHLO mail-pw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755509Ab0F3Tq6 (ORCPT ); Wed, 30 Jun 2010 15:46:58 -0400 In-Reply-To: <25800.1277889215@redhat.com> Sender: linux-acpi-owner@vger.kernel.org List-Id: linux-acpi@vger.kernel.org To: David Howells Cc: linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, lenb@kernel.org o.k. hopefully this is getting close to being right.. I ended up spending the later half of the morning looking for dev_driver_string(dev) until I read device.h and realized you actually use that it's self to gather the debug info etc..(I admit it, I'm a newbie!) anyways here is the updated patch, let me know if something need a changing.. From 16df81551d1899e650ae28ea8d41931f7c391c7a Mon Sep 17 00:00:00 2001 From: Justin P. Mattock Date: Wed, 30 Jun 2010 12:34:32 -0700 Subject: [PATCH]acpi:glue.c Fix Fix warning: variable 'ret' set but not used Fix a warning message generated by gcc: Im getting a warning message when building with gcc 4.6.0 CC drivers/acpi/glue.o drivers/acpi/glue.c: In function 'acpi_bind_one': drivers/acpi/glue.c:163:7: warning: variable 'ret' set but not used Signed-off-by: Justin P. Mattock Signed-off-by: David Howells --- drivers/acpi/glue.c | 16 +++++++++++++--- 1 files changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/acpi/glue.c b/drivers/acpi/glue.c index 4af6301..11ad510 100644 --- a/drivers/acpi/glue.c +++ b/drivers/acpi/glue.c @@ -145,6 +145,7 @@ static int acpi_bind_one(struct device *dev, acpi_handle handle) { struct acpi_device *acpi_dev; acpi_status status; + int fn, pn; if (dev->archdata.acpi_handle) { dev_warn(dev, "Drivers changed 'acpi_handle'\n"); @@ -160,12 +161,21 @@ static int acpi_bind_one(struct device *dev, acpi_handle handle) status = acpi_bus_get_device(handle, &acpi_dev); if (!ACPI_FAILURE(status)) { - int ret; - ret = sysfs_create_link(&dev->kobj, &acpi_dev->dev.kobj, + fn = sysfs_create_link(&dev->kobj, &acpi_dev->dev.kobj, "firmware_node"); - ret = sysfs_create_link(&acpi_dev->dev.kobj, &dev->kobj, + pn = sysfs_create_link(&acpi_dev->dev.kobj, &dev->kobj, "physical_node"); + if (fn) { + dev_warn(&acpi_dev->dev, + "Failed to create firmware_node link to %s %s: %d\n", + dev_driver_string(dev), dev_name(dev), fn); + } else if (pn) { + dev_warn(&acpi_dev->dev, + "Failed to create physical_node link to %s %s: %d\n", + dev_driver_string(dev), dev_name(dev), pn); + return AE_ERROR; + } if (acpi_dev->wakeup.flags.valid) { device_set_wakeup_capable(dev, true); device_set_wakeup_enable(dev, -- 1.7.1.rc1.21.gf3bd6 cheers, Justin P. Mattock