From: Kevin Wolf <kwolf@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: hch@lst.de, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: [Qemu-devel] Re: [PATCH 04/11] scsi: Reject unimplemented error actions
Date: Mon, 05 Jul 2010 17:39:30 +0200 [thread overview]
Message-ID: <4C31FCB2.8050207@redhat.com> (raw)
In-Reply-To: <1277898942-6501-5-git-send-email-armbru@redhat.com>
Am 30.06.2010 13:55, schrieb Markus Armbruster:
> drive_init() doesn't permit rerror for if=scsi, but that's worthless:
> we get it via if=none and -device.
>
> Moreover, scsi-generic doesn't support werror. Since drive_init()
> doesn't catch that, option werror was silently ignored even with
> if=scsi.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
It's still not entirely right, of course. You can explicitly request
werror=enospc and the VM will start successfully, but silently ignore
ENOSPC errors.
Anyway, it's better than before.
Kevin
next prev parent reply other threads:[~2010-07-05 15:39 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 11:55 [Qemu-devel] [PATCH 00/11] Still more block related fixes and cleanups Markus Armbruster
2010-06-30 11:55 ` [Qemu-devel] [PATCH 01/11] blockdev: Clean up how readonly persists across virtual media change Markus Armbruster
2010-06-30 11:55 ` [Qemu-devel] [PATCH 02/11] block migration: Fix test for read-only drive Markus Armbruster
2010-06-30 11:55 ` [Qemu-devel] [PATCH 03/11] raw-posix: Don't "try harder" for BDRV_TYPE_CDROM Markus Armbruster
2010-07-05 15:31 ` [Qemu-devel] " Kevin Wolf
2010-07-05 16:15 ` Markus Armbruster
2010-07-05 16:35 ` Kevin Wolf
2010-06-30 11:55 ` [Qemu-devel] [PATCH 04/11] scsi: Reject unimplemented error actions Markus Armbruster
2010-07-05 15:39 ` Kevin Wolf [this message]
2010-07-05 16:26 ` [Qemu-devel] " Markus Armbruster
2010-06-30 11:55 ` [Qemu-devel] [PATCH 05/11] fdc: " Markus Armbruster
2010-06-30 11:55 ` [Qemu-devel] [PATCH 06/11] qdev: Don't hw_error() in qdev_init_nofail() Markus Armbruster
2010-06-30 11:55 ` [Qemu-devel] [PATCH 07/11] ide: Improve error messages Markus Armbruster
2010-06-30 11:55 ` [Qemu-devel] [PATCH 08/11] ide: Replace IDEState members is_cdrom, is_cf by drive_kind Markus Armbruster
2010-07-05 16:00 ` [Qemu-devel] " Kevin Wolf
2010-07-06 12:38 ` Markus Armbruster
2010-07-06 12:50 ` Kevin Wolf
2010-06-30 11:55 ` [Qemu-devel] [PATCH 09/11] ide: Make ide_init_drive() return success Markus Armbruster
2010-06-30 11:55 ` [Qemu-devel] [PATCH 10/11] ide: Reject readonly drives unless CD-ROM Markus Armbruster
2010-06-30 11:55 ` [Qemu-devel] [PATCH 11/11] ide: Reject invalid CHS geometry Markus Armbruster
2010-07-05 16:08 ` [Qemu-devel] Re: [PATCH 00/11] Still more block related fixes and cleanups Kevin Wolf
2010-07-05 16:28 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4C31FCB2.8050207@redhat.com \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=hch@lst.de \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.