Re: When IBoE will be merged to upstream?

From: Or Gerlitz <ogerlitz-hKgKHo2Ms0FWk0Htik3J/w@public.gmane.org>
To: Liran Liss <liranl-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
Cc: Roland Dreier <rdreier-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>,
	Jason Gunthorpe
	<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>,
	"Hefty,
	Sean" <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>,
	Aleksey Senin <aleksey-192fA4vuk7xBDLzU/O5InQ@public.gmane.org>,
	linux-rdma <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
	"monis-smomgflXvOZWk0Htik3J/w@public.gmane.org"
	<monis-smomgflXvOZWk0Htik3J/w@public.gmane.org>,
	"alekseys-smomgflXvOZWk0Htik3J/w@public.gmane.org"
	<alekseys-smomgflXvOZWk0Htik3J/w@public.gmane.org>,
	"yiftahs-smomgflXvOZWk0Htik3J/w@public.gmane.org"
	<yiftahs-smomgflXvOZWk0Htik3J/w@public.gmane.org>,
	Tziporet Koren <tziporet-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>,
	"alexr-smomgflXvOZWk0Htik3J/w@public.gmane.org"
	<alexr-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Subject: Re: When IBoE will be merged to upstream?
Date: Tue, 06 Jul 2010 09:44:13 +0300	[thread overview]
Message-ID: <4C32D0BD.3030902@Voltaire.com> (raw)
In-Reply-To: <E113D394D7C5DB4F8FF691FA7EE9DB443A8E048000-WQlSmcKwN8Te+A/uUDamNg@public.gmane.org>

Liran Liss wrote:
> S.B

reading your replies would be much easier if you use strict bottom posting

>> For a long time we've assumed that the create_ah verb can't sleep, 
>> so where are you going to do neighbor discovery?

> re [...] implementation, there is no inherent issue that prevents create_ah() from sleeping:
> - Change a few spinlocks to mutexes in the cma (which sleeps a lot anyway because is 
>   modifies QP states)
> - Trivial for user-space calls...

Documentation/infiniband/core_locking.txt states that "The corresponding functions exported to upper level protocol consumers: ... ib_create_ah ... are therefore safe to call from any context." 

Which is in turn assumed by bunch of components in the kernel IB stack (look for ib_create_ah calls  under drivers/infiniband/core/). The examples you brought here, don't cover them. This way or another, I don't see any reason to break that convension just for the sake of this aspect of the iboe implementation, simply, code with this assumption at hand.

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html